From: "Krzysztof Wilczyński" <kwilczynski@kernel•org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux•intel.com>
Cc: "Bjorn Helgaas" <bhelgaas@google•com>,
"Bjorn Helgaas" <helgaas@kernel•org>,
"Manivannan Sadhasivam" <mani@kernel•org>,
"Lorenzo Pieralisi" <lpieralisi@kernel•org>,
"Magnus Lindholm" <linmag7@gmail•com>,
"Matt Turner" <mattst88@gmail•com>,
"Richard Henderson" <richard.henderson@linaro•org>,
"Christophe Leroy" <chleroy@kernel•org>,
"Madhavan Srinivasan" <maddy@linux•ibm.com>,
"Michael Ellerman" <mpe@ellerman•id.au>,
"Nicholas Piggin" <npiggin@gmail•com>,
"Dexuan Cui" <decui@microsoft•com>,
"Krzysztof Hałasa" <khalasa@piap•pl>,
"Lukas Wunner" <lukas@wunner•de>,
"Oliver O'Halloran" <oohall@gmail•com>,
"Saurabh Singh Sengar" <ssengar@microsoft•com>,
"Shuan He" <heshuan@bytedance•com>,
"Srivatsa Bhat" <srivatsabhat@microsoft•com>,
linux-pci@vger•kernel.org, linux-alpha@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH 14/20] alpha/PCI: Add static PCI resource attribute macros
Date: Fri, 10 Apr 2026 20:48:52 +0900 [thread overview]
Message-ID: <20260410114852.GA1761359@rocinante> (raw)
In-Reply-To: <2c5b50c7-b357-025d-e0de-1fce1fcddf20@linux.intel.com>
Hello,
> > +#define __pci_dev_resource_attr(_bar, _name, _suffix, _mmap) \
> > +static const struct bin_attribute \
> > +pci_dev_resource##_bar##_suffix##_attr = { \
> > + .attr = { .name = __stringify(_name), .mode = 0600 }, \
> > + .private = (void *)(unsigned long)(_bar), \
> > + .mmap = (_mmap), \
> > +}
> > +
> > +#define pci_dev_resource_attr(_bar) \
> > + __pci_dev_resource_attr(_bar, resource##_bar,, \
> > + pci_mmap_resource_dense)
> > +
> > +#define pci_dev_resource_sparse_attr(_bar) \
> > + __pci_dev_resource_attr(_bar, resource##_bar##_sparse, _sparse, \
> > + pci_mmap_resource_sparse)
> > +
> > +#define pci_dev_resource_dense_attr(_bar) \
> > + __pci_dev_resource_attr(_bar, resource##_bar##_dense, _dense, \
> > + pci_mmap_resource_dense)
> > +
> > /**
> > * pci_remove_resource_files - cleanup resource files
> > * @pdev: pci_dev to cleanup
> >
>
> Wouldn't this belong together with the next patch, or is there some good
> reason why you added them separately?
No specific reason other than to make it easier to review. The pattern
here is: macros first and then users later (when converting things over).
Thank you!
Krzysztof
next prev parent reply other threads:[~2026-04-10 11:48 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 5:50 [PATCH 00/20] PCI: Convert all dynamic sysfs attributes to static Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 01/20] PCI/sysfs: Use PCI resource accessor macros Krzysztof Wilczyński
2026-04-10 10:20 ` Ilpo Järvinen
2026-04-10 5:50 ` [PATCH 02/20] PCI/sysfs: Only allow supported resource types in I/O and MMIO helpers Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 03/20] PCI/sysfs: Use BAR length in pci_llseek_resource() when attr->size is zero Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 04/20] PCI/sysfs: Add CAP_SYS_ADMIN check to __resource_resize_store() Krzysztof Wilczyński
2026-04-10 10:18 ` Ilpo Järvinen
2026-04-10 5:50 ` [PATCH 05/20] PCI/sysfs: Add static PCI resource attribute macros Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 06/20] PCI/sysfs: Convert PCI resource files to static attributes Krzysztof Wilczyński
2026-04-10 10:49 ` Ilpo Järvinen
2026-04-10 11:13 ` Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 07/20] PCI/sysfs: Convert __resource_resize_store() to use " Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 08/20] PCI/sysfs: Add stubs for pci_{create,remove}_sysfs_dev_files() Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 09/20] PCI/sysfs: Limit pci_sysfs_init() late_initcall compile scope Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 10/20] alpha/PCI: Add security_locked_down() check to pci_mmap_resource() Krzysztof Wilczyński
2026-04-10 11:04 ` Ilpo Järvinen
2026-04-10 11:10 ` Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros Krzysztof Wilczyński
2026-04-10 11:11 ` Ilpo Järvinen
2026-04-10 11:27 ` Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 13/20] alpha/PCI: Clean up __pci_mmap_fits() Krzysztof Wilczyński
2026-04-10 11:14 ` Ilpo Järvinen
2026-04-10 11:21 ` Krzysztof Wilczyński
2026-04-10 11:32 ` Ilpo Järvinen
2026-04-10 11:55 ` Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 14/20] alpha/PCI: Add static PCI resource attribute macros Krzysztof Wilczyński
2026-04-10 11:19 ` Ilpo Järvinen
2026-04-10 11:48 ` Krzysztof Wilczyński [this message]
2026-04-10 5:50 ` [PATCH 15/20] alpha/PCI: Convert resource files to static attributes Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 16/20] PCI/sysfs: Remove pci_{create,remove}_sysfs_dev_files() Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 17/20] alpha/PCI: Compute legacy size in pci_mmap_legacy_page_range() Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 18/20] PCI/sysfs: Add __weak pci_legacy_has_sparse() helper Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 19/20] PCI/sysfs: Convert legacy I/O and memory attributes to static definitions Krzysztof Wilczyński
2026-04-10 11:47 ` Ilpo Järvinen
2026-04-10 12:04 ` Krzysztof Wilczyński
2026-04-10 5:50 ` [PATCH 20/20] PCI/sysfs: Remove pci_create_legacy_files() and pci_sysfs_init() Krzysztof Wilczyński
2026-04-10 18:18 ` [PATCH 00/20] PCI: Convert all dynamic sysfs attributes to static Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260410114852.GA1761359@rocinante \
--to=kwilczynski@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=chleroy@kernel$(echo .)org \
--cc=decui@microsoft$(echo .)com \
--cc=helgaas@kernel$(echo .)org \
--cc=heshuan@bytedance$(echo .)com \
--cc=ilpo.jarvinen@linux$(echo .)intel.com \
--cc=khalasa@piap$(echo .)pl \
--cc=linmag7@gmail$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lpieralisi@kernel$(echo .)org \
--cc=lukas@wunner$(echo .)de \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mani@kernel$(echo .)org \
--cc=mattst88@gmail$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=oohall@gmail$(echo .)com \
--cc=richard.henderson@linaro$(echo .)org \
--cc=srivatsabhat@microsoft$(echo .)com \
--cc=ssengar@microsoft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox