From: "Krzysztof Wilczyński" <kwilczynski@kernel•org>
To: Bjorn Helgaas <bhelgaas@google•com>
Cc: "Bjorn Helgaas" <helgaas@kernel•org>,
"Manivannan Sadhasivam" <mani@kernel•org>,
"Lorenzo Pieralisi" <lpieralisi@kernel•org>,
"Magnus Lindholm" <linmag7@gmail•com>,
"Matt Turner" <mattst88@gmail•com>,
"Richard Henderson" <richard.henderson@linaro•org>,
"Christophe Leroy" <chleroy@kernel•org>,
"Madhavan Srinivasan" <maddy@linux•ibm.com>,
"Michael Ellerman" <mpe@ellerman•id.au>,
"Nicholas Piggin" <npiggin@gmail•com>,
"Dexuan Cui" <decui@microsoft•com>,
"Krzysztof Hałasa" <khalasa@piap•pl>,
"Lukas Wunner" <lukas@wunner•de>,
"Oliver O'Halloran" <oohall@gmail•com>,
"Saurabh Singh Sengar" <ssengar@microsoft•com>,
"Shuan He" <heshuan@bytedance•com>,
"Srivatsa Bhat" <srivatsabhat@microsoft•com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux•intel.com>,
linux-pci@vger•kernel.org, linux-alpha@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org
Subject: [PATCH v4 01/24] PCI/sysfs: Use PCI resource accessor macros
Date: Sat, 11 Apr 2026 08:01:25 +0000 [thread overview]
Message-ID: <20260411080148.471335-2-kwilczynski@kernel.org> (raw)
In-Reply-To: <20260411080148.471335-1-kwilczynski@kernel.org>
Replace direct pdev->resource[] accesses with pci_resource_n(),
and pdev->resource[].flags accesses with pci_resource_flags().
No functional changes intended.
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux•intel.com>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel•org>
---
drivers/pci/pci-sysfs.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 16eaaf749ba9..ad3c17f86c7f 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -177,7 +177,7 @@ static ssize_t resource_show(struct device *dev, struct device_attribute *attr,
max = PCI_BRIDGE_RESOURCES;
for (i = 0; i < max; i++) {
- struct resource *res = &pci_dev->resource[i];
+ struct resource *res = pci_resource_n(pci_dev, i);
struct resource zerores = {};
/* For backwards compatibility */
@@ -715,7 +715,7 @@ static ssize_t boot_vga_show(struct device *dev, struct device_attribute *attr,
return sysfs_emit(buf, "%u\n", (pdev == vga_dev));
return sysfs_emit(buf, "%u\n",
- !!(pdev->resource[PCI_ROM_RESOURCE].flags &
+ !!(pci_resource_flags(pdev, PCI_ROM_RESOURCE) &
IORESOURCE_ROM_SHADOW));
}
static DEVICE_ATTR_RO(boot_vga);
@@ -1108,7 +1108,7 @@ static int pci_mmap_resource(struct kobject *kobj, const struct bin_attribute *a
struct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));
int bar = (unsigned long)attr->private;
enum pci_mmap_state mmap_type;
- struct resource *res = &pdev->resource[bar];
+ struct resource *res = pci_resource_n(pdev, bar);
int ret;
ret = security_locked_down(LOCKDOWN_PCI_ACCESS);
@@ -1312,7 +1312,7 @@ static int pci_create_resource_files(struct pci_dev *pdev)
retval = pci_create_attr(pdev, i, 0);
/* for prefetchable resources, create a WC mappable file */
if (!retval && arch_can_pci_mmap_wc() &&
- pdev->resource[i].flags & IORESOURCE_PREFETCH)
+ pci_resource_flags(pdev, i) & IORESOURCE_PREFETCH)
retval = pci_create_attr(pdev, i, 1);
if (retval) {
pci_remove_resource_files(pdev);
--
2.53.0
next prev parent reply other threads:[~2026-04-11 8:02 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-11 8:01 [PATCH v4 00/24] PCI: Convert all dynamic sysfs attributes to static Krzysztof Wilczyński
2026-04-11 8:01 ` Krzysztof Wilczyński [this message]
2026-04-11 8:01 ` [PATCH v4 02/24] PCI: Add pci_resource_is_io() and pci_resource_is_mem() helpers Krzysztof Wilczyński
2026-04-13 11:19 ` Ilpo Järvinen
2026-04-11 8:01 ` [PATCH v4 03/24] PCI/sysfs: Only allow supported resource types in I/O and MMIO helpers Krzysztof Wilczyński
2026-04-13 11:24 ` Ilpo Järvinen
2026-04-11 8:01 ` [PATCH v4 04/24] PCI/sysfs: Use BAR length in pci_llseek_resource() when attr->size is zero Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 05/24] PCI/sysfs: Add CAP_SYS_ADMIN check to __resource_resize_store() Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 06/24] PCI/sysfs: Add static PCI resource attribute macros Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 07/24] PCI/sysfs: Convert PCI resource files to static attributes Krzysztof Wilczyński
2026-04-13 11:33 ` Ilpo Järvinen
2026-04-17 11:49 ` Krzysztof Wilczyński
2026-04-20 9:47 ` Ilpo Järvinen
2026-04-11 8:01 ` [PATCH v4 08/24] PCI/sysfs: Convert __resource_resize_store() to use " Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 09/24] PCI/sysfs: Add stubs for pci_{create,remove}_sysfs_dev_files() Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 10/24] PCI/sysfs: Limit pci_sysfs_init() late_initcall compile scope Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 11/24] alpha/PCI: Add security_locked_down() check to pci_mmap_resource() Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 12/24] alpha/PCI: Use BAR index in sysfs attr->private instead of resource pointer Krzysztof Wilczyński
2026-04-13 11:51 ` Ilpo Järvinen
2026-04-17 10:48 ` Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 13/24] alpha/PCI: Use PCI resource accessor macros Krzysztof Wilczyński
2026-04-13 11:52 ` Ilpo Järvinen
2026-04-17 10:48 ` Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 14/24] alpha/PCI: Clean up pci_mmap_resource() Krzysztof Wilczyński
2026-04-13 11:54 ` Ilpo Järvinen
2026-04-11 8:01 ` [PATCH v4 15/24] alpha/PCI: Fix __pci_mmap_fits() overflow for zero-length BARs Krzysztof Wilczyński
2026-04-13 11:44 ` Ilpo Järvinen
2026-04-11 8:01 ` [PATCH v4 16/24] alpha/PCI: Remove WARN from __pci_mmap_fits() Krzysztof Wilczyński
2026-04-13 11:45 ` Ilpo Järvinen
2026-04-11 8:01 ` [PATCH v4 17/24] alpha/PCI: Add static PCI resource attribute macros Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 18/24] alpha/PCI: Convert resource files to static attributes Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 19/24] PCI/sysfs: Remove pci_{create,remove}_sysfs_dev_files() Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 20/24] PCI: Add macros for legacy I/O and memory address space sizes Krzysztof Wilczyński
2026-04-13 11:59 ` Ilpo Järvinen
2026-04-17 10:46 ` Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 21/24] alpha/PCI: Compute legacy size in pci_mmap_legacy_page_range() Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 22/24] PCI/sysfs: Add __weak pci_legacy_has_sparse() helper Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 23/24] PCI/sysfs: Convert legacy I/O and memory attributes to static definitions Krzysztof Wilczyński
2026-04-11 8:01 ` [PATCH v4 24/24] PCI/sysfs: Remove pci_create_legacy_files() and pci_sysfs_init() Krzysztof Wilczyński
2026-04-11 10:40 ` [PATCH v4 00/24] PCI: Convert all dynamic sysfs attributes to static Magnus Lindholm
2026-04-12 6:39 ` Krzysztof Wilczyński
2026-04-12 6:38 ` Krzysztof Wilczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260411080148.471335-2-kwilczynski@kernel.org \
--to=kwilczynski@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=chleroy@kernel$(echo .)org \
--cc=decui@microsoft$(echo .)com \
--cc=helgaas@kernel$(echo .)org \
--cc=heshuan@bytedance$(echo .)com \
--cc=ilpo.jarvinen@linux$(echo .)intel.com \
--cc=khalasa@piap$(echo .)pl \
--cc=linmag7@gmail$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lpieralisi@kernel$(echo .)org \
--cc=lukas@wunner$(echo .)de \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mani@kernel$(echo .)org \
--cc=mattst88@gmail$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=npiggin@gmail$(echo .)com \
--cc=oohall@gmail$(echo .)com \
--cc=richard.henderson@linaro$(echo .)org \
--cc=srivatsabhat@microsoft$(echo .)com \
--cc=ssengar@microsoft$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox