From: Athira Rajeev <atrajeev@linux•ibm.com>
To: acme@kernel•org, jolsa@kernel•org, adrian.hunter@intel•com,
mpetlan@redhat•com, tmricht@linux•ibm.com, maddy@linux•ibm.com,
irogers@google•com, namhyung@kernel•org
Cc: linux-perf-users@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
atrajeev@linux•ibm.com, hbathini@linux•vnet.ibm.com,
Tejas.Manhas1@ibm•com, Tanushree.Shah@ibm•com,
shivani@linux•ibm.com
Subject: [PATCH V4 1/2] tools/perf: Fix the check for parameterized field in event term
Date: Mon, 4 May 2026 21:12:04 +0530 [thread overview]
Message-ID: <20260504154205.21394-1-atrajeev@linux.ibm.com> (raw)
The format_alias() function in util/pmu.c has a check to
detect whether the event has parameterized field ( =? ).
The string alias->terms contains the event and if the event
has user configurable parameter, there will be presence of
sub string "=?" in the alias->terms.
Snippet of code:
/* Paramemterized events have the parameters shown. */
if (strstr(alias->terms, "=?")) {
/* No parameters. */
snprintf(buf, len, "%.*s/%s/", (int)pmu_name_len, pmu->name, alias->name);
if "strstr" contains the substring, it returns a pointer
and hence enters the above check which is not the expected
check. And hence "perf list" doesn't have the parameterized
fields in the result.
Fix this check to use:
if (!strstr(alias->terms, "=?")) {
With this change, perf list shows the events correctly with
the strings showing parameters.
Before the fix:
# ./perf list|grep -w PM_PAU_CYC
hv_24x7/PM_PAU_CYC/ [Kernel PMU event]
With this fix:
# ./perf list|grep -w PM_PAU_CYC
hv_24x7/PM_PAU_CYC,chip=?/ [Kernel PMU event]
Signed-off-by: Athira Rajeev <atrajeev@linux•ibm.com>
---
Changelog:
v3 -> v4:
Updated commit message to show real example
addressing review comment from Namhyung.
v2 -> v3:
Split the strstr correction in a single patch
tools/perf/util/pmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c
index 23337d2fa281..0b8d58543f17 100644
--- a/tools/perf/util/pmu.c
+++ b/tools/perf/util/pmu.c
@@ -2117,7 +2117,7 @@ static char *format_alias(char *buf, int len, const struct perf_pmu *pmu,
skip_duplicate_pmus);
/* Paramemterized events have the parameters shown. */
- if (strstr(alias->terms, "=?")) {
+ if (!strstr(alias->terms, "=?")) {
/* No parameters. */
snprintf(buf, len, "%.*s/%s/", (int)pmu_name_len, pmu->name, alias->name);
return buf;
--
2.47.3
next reply other threads:[~2026-05-04 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 15:42 Athira Rajeev [this message]
2026-05-04 15:42 ` [PATCH V4 2/2] tools/perf: Use scnprintf in buffer offset calculations Athira Rajeev
2026-05-13 1:02 ` Ian Rogers
2026-06-04 22:02 ` Namhyung Kim
2026-05-12 8:52 ` [PATCH V4 1/2] tools/perf: Fix the check for parameterized field in event term Venkat
2026-05-13 0:57 ` Ian Rogers
2026-05-21 6:37 ` Athira Rajeev
2026-06-04 15:12 ` Athira Rajeev
2026-06-04 21:52 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504154205.21394-1-atrajeev@linux.ibm.com \
--to=atrajeev@linux$(echo .)ibm.com \
--cc=Tanushree.Shah@ibm$(echo .)com \
--cc=Tejas.Manhas1@ibm$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=hbathini@linux$(echo .)vnet.ibm.com \
--cc=irogers@google$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mpetlan@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=shivani@linux$(echo .)ibm.com \
--cc=tmricht@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox