From: Jakub Kicinski <kuba@kernel•org>
To: Holger Brunck <holger.brunck@hitachienergy•com>
Cc: "Christophe Leroy (CS GROUP)" <chleroy@kernel•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"andrew+netdev@lunn•ch" <andrew+netdev@lunn•ch>,
"qiang.zhao@nxp•com" <qiang.zhao@nxp•com>,
"horms@kernel•org" <horms@kernel•org>
Subject: Re: [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in uhdlc_memclean
Date: Tue, 5 May 2026 16:47:36 -0700 [thread overview]
Message-ID: <20260505164736.26d203a8@kernel.org> (raw)
In-Reply-To: <AM0PR06MB103966EF99B706158C49CB3EAF73E2@AM0PR06MB10396.eurprd06.prod.outlook.com>
On Tue, 5 May 2026 08:33:34 +0000 Holger Brunck wrote:
> > I don't think you can just kfree() an skb like this.
> >
> > I think you have to call dev_kfree_skb_any() instead.
>
> yes you are right or at least dev_kfree_skb() as the error handling code in
> ucc_hdlc_tx does.
Please make it clear in the commit message how you discovered
the issue and how you tested your patches.
next prev parent reply other threads:[~2026-05-05 23:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 16:11 [PATCH net] net: wan: fsl_ucc_hdlc: free tx_skbuff in uhdlc_memclean Holger Brunck
2026-05-05 5:37 ` Christophe Leroy (CS GROUP)
2026-05-05 8:33 ` Holger Brunck
2026-05-05 23:47 ` Jakub Kicinski [this message]
2026-05-06 8:27 ` Holger Brunck
2026-05-15 3:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505164736.26d203a8@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=chleroy@kernel$(echo .)org \
--cc=holger.brunck@hitachienergy$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=qiang.zhao@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox