public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: David Laight <david.laight.linux@gmail•com>
To: Paul Moore <paul@paul-moore•com>
Cc: Venkat Rao Bagalkote <venkat88@linux•ibm.com>,
	linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
	Madhavan Srinivasan <maddy@linux•ibm.com>,
	selinux@vger•kernel.org, rppt@kernel•org,
	LKML <linux-kernel@vger•kernel.org>,
	Ritesh Harjani <riteshh@linux•ibm.com>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel•org>
Subject: Re: PowerPC: Random memory corruption causing kernel oops on Power11
Date: Sat, 30 May 2026 12:03:03 +0100	[thread overview]
Message-ID: <20260530120303.1b441fdc@pumpkin> (raw)
In-Reply-To: <CAHC9VhRAbCAxg4swOCBT+nAUaqRPsdBuOa+nm=539ejpN4wmWQ@mail.gmail.com>

On Fri, 29 May 2026 14:23:06 -0400
Paul Moore <paul@paul-moore•com> wrote:

> On Fri, May 29, 2026 at 12:18 PM David Laight
...
> > PAGE_SIZE is not the length of the buffer.
> > Should be PATH_MAX.  
> 
> Yes, as discussed earlier in the thread some additional work needs to
> be done, and verified, but since we are at the end of -rc5 I simply
> reverted the patch.  We can chase this down next dev cycle.
> 

Emails crossed in the afternoon...

Like many of these changes the buffer size should never have been PAGE_SIZE.
Clearly here PATH_MAX is the best way to say 4096.
But I suspect some of the others should be (say) BUF_4K.

I wonder how much userspace code is left that does 'char buf[BUFSIZE]' and
just assumes it is 'big enough'.

-- David


      reply	other threads:[~2026-05-30 11:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29  6:50 PowerPC: Random memory corruption causing kernel oops on Power11 Venkat Rao Bagalkote
2026-05-29 13:37 ` Venkat Rao Bagalkote
2026-05-29 15:02   ` Stephen Smalley
2026-05-29 15:19     ` Stephen Smalley
2026-05-29 15:39       ` Paul Moore
2026-05-29 16:11         ` Stephen Smalley
2026-05-29 18:24           ` Paul Moore
2026-05-29 16:18   ` David Laight
2026-05-29 18:23     ` Paul Moore
2026-05-30 11:03       ` David Laight [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260530120303.1b441fdc@pumpkin \
    --to=david.laight.linux@gmail$(echo .)com \
    --cc=chleroy@kernel$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=maddy@linux$(echo .)ibm.com \
    --cc=paul@paul-moore$(echo .)com \
    --cc=riteshh@linux$(echo .)ibm.com \
    --cc=rppt@kernel$(echo .)org \
    --cc=selinux@vger$(echo .)kernel.org \
    --cc=venkat88@linux$(echo .)ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox