From: Michael Neuling <mikey@neuling•org>
To: Anton Blanchard <anton@samba•org>
Cc: paulus@samba•org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH] powerpc: Lack! of! ibm,io-events! not! that! important!
Date: Mon, 01 Aug 2011 20:29:12 +1000 [thread overview]
Message-ID: <21003.1312194552@neuling.org> (raw)
In-Reply-To: <20110801153004.0e8af5df@kryten>
In message <20110801153004.0e8af5df@kryten> you wrote:
>
> The ibm,io-events code is a bit verbose with its error messages.
> Reverse the reporting so we only print when we successfully enable
> I/O event interrupts.
NAK!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Mikey
PS :-)
PPS !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> Signed-off-by: Anton Blanchard <anton@samba•org>
> ---
>
> Index: linux-powerpc/arch/powerpc/platforms/pseries/io_event_irq.c
> ===================================================================
> --- linux-powerpc.orig/arch/powerpc/platforms/pseries/io_event_irq.c 2011-07
-26 08:50:11.291231586 +1000
> +++ linux-powerpc/arch/powerpc/platforms/pseries/io_event_irq.c 2011-07
-26 08:51:39.992772071 +1000
> @@ -212,17 +212,15 @@ static int __init ioei_init(void)
> struct device_node *np;
>
> ioei_check_exception_token = rtas_token("check-exception");
> - if (ioei_check_exception_token == RTAS_UNKNOWN_SERVICE) {
> - pr_warning("IO Event IRQ not supported on this system !\n");
> + if (ioei_check_exception_token == RTAS_UNKNOWN_SERVICE)
> return -ENODEV;
> - }
> +
> np = of_find_node_by_path("/event-sources/ibm,io-events");
> if (np) {
> request_event_sources_irqs(np, ioei_interrupt, "IO_EVENT");
> + pr_info("IBM I/O event interrupts enabled\n");
> of_node_put(np);
> } else {
> - pr_err("io_event_irq: No ibm,io-events on system! "
> - "IO Event interrupt disabled.\n");
> return -ENODEV;
> }
> return 0;
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists•ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
prev parent reply other threads:[~2011-08-01 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 5:30 [PATCH] powerpc: Lack! of! ibm,io-events! not! that! important! Anton Blanchard
2011-08-01 10:29 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21003.1312194552@neuling.org \
--to=mikey@neuling$(echo .)org \
--cc=anton@samba$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox