From: Alistair Popple <alistair@popple•id.au>
To: Paul Bolle <pebolle@tiscali•nl>, Jiri Kosina <trivial@kernel•org>
Cc: linuxppc-dev@ozlabs•org, linux-kernel@vger•kernel.org,
Valentin Rothberg <valentinrothberg@gmail•com>
Subject: Re: [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL
Date: Tue, 23 Dec 2014 09:48:23 +1100 [thread overview]
Message-ID: <2224792.Nmvmc626jj@mexican> (raw)
In-Reply-To: <1419243273.30945.19.camel@x220>
Hi Paul,
These days I've been made maintainer of the PPC4XX tree so maybe adding Acked-
by: Alistair Popple <alistair@popple•id.au> might help?
Jiri, if you would rather this go via the main PPC tree please let us know and
we'll see if Michael Ellerman (added to CC) would be willing to take it (he
has taken over most of the day to day maintenance of the PPC tree). Thanks!
Regards,
Alistair
On Mon, 22 Dec 2014 11:14:33 Paul Bolle wrote:
> Hi Jiri,
>
> On Mon, 2014-11-03 at 10:52 +0100, Paul Bolle wrote:
> > Commit 2a2c74b2efcb ("IBM Akebono: Add the Akebono platform") added a
> > select of IBM_EMAC_RGMII_WOL. But that Kconfig symbol isn't (yet) part
> > of the tree. So this select has been a nop since that commit was
> > included in v3.16-rc1.
> >
> > The code to add this symbol is not included in next-20141103. So let's
> > remove this select. It can be readded when that symbol is actually added
> > to the tree.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali•nl>
> > Cc: Alistair Popple <alistair@popple•id.au>
> > ---
> > Untested. Done on top of next-20141103.
> >
> > Third time's a charm? First raised in
> > https://lkml.org/lkml/2014/5/1/106 . Reminder sent in
> > https://lkml.org/lkml/2014/9/4/645 . I'm not aware of any news on this
> > front, so this trivial patch seems reasonable now.
> >
> > A patch to readd this select could be added - if people still care about
> > it, that is - in the series that adds this symbol. A web search suggests
> > Alistair takes care of that series, so Alistair gets a Cc: here.
>
> This select of IBM_EMAC_RGMII_WOL still shows up in next-20141221 and
> v3.19-rc1. Did you have a chance to look at this patch?
>
> > arch/powerpc/platforms/44x/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/powerpc/platforms/44x/Kconfig
> > b/arch/powerpc/platforms/44x/Kconfig index d2ac1c116454..5538e57c36c1
> > 100644
> > --- a/arch/powerpc/platforms/44x/Kconfig
> > +++ b/arch/powerpc/platforms/44x/Kconfig
> > @@ -214,7 +214,6 @@ config AKEBONO
> >
> > select ETHERNET
> > select NET_VENDOR_IBM
> > select IBM_EMAC_EMAC4
> >
> > - select IBM_EMAC_RGMII_WOL
> >
> > select USB if USB_SUPPORT
> > select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
> > select USB_EHCI_HCD_PLATFORM if USB_EHCI_HCD
>
> Thanks,
>
>
> Paul Bolle
next parent reply other threads:[~2014-12-22 22:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1415008333.20372.26.camel@x220>
[not found] ` <1419243273.30945.19.camel@x220>
2014-12-22 22:48 ` Alistair Popple [this message]
2014-12-23 0:31 ` [PATCH] [TRIVIAL] IBM Akebono: Remove select of IBM_EMAC_RGMII_WOL Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2224792.Nmvmc626jj@mexican \
--to=alistair@popple$(echo .)id.au \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=pebolle@tiscali$(echo .)nl \
--cc=trivial@kernel$(echo .)org \
--cc=valentinrothberg@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox