From: Michael Neuling <mikey@neuling•org>
To: Anton Blanchard <anton@samba•org>
Cc: paulus@samba•org, linuxppc-dev@lists•ozlabs.org, miltonm@bga•com,
kexec@lists•infradead.org
Subject: Re: [PATCH] powerpc: pseries: Fix kexec on machines with more than 4TB of RAM
Date: Wed, 27 Jul 2011 14:26:10 +1000 [thread overview]
Message-ID: <2294.1311740770@neuling.org> (raw)
In-Reply-To: <20110727141503.3faa93f5@kryten>
> On a box with 8TB of RAM the MMU hashtable is 64GB in size. That
> means we have 4G PTEs. pSeries_lpar_hptab_clear was using a signed
> int to store the index which will overflow at 2G.
Wow, I hear... "Anton Blanchard's machine has more memory in it's MMU
than you have in total".
Acked-by: Michael Neuling <mikey@neuling•org>
>
> Signed-off-by: Anton Blanchard <anton@samba•org>
> Cc: <stable@kernel•org>
> ---
>
> Index: linux-powerpc/arch/powerpc/platforms/pseries/lpar.c
> ===================================================================
> --- linux-powerpc.orig/arch/powerpc/platforms/pseries/lpar.c 2011-07-27 13:5
0:18.408091576 +1000
> +++ linux-powerpc/arch/powerpc/platforms/pseries/lpar.c 2011-07-27 13:5
1:19.359196131 +1000
> @@ -203,7 +203,7 @@ static void pSeries_lpar_hptab_clear(voi
> unsigned long ptel;
> } ptes[4];
> long lpar_rc;
> - int i, j;
> + unsigned long i, j;
>
> /* Read in batches of 4,
> * invalidate only valid entries not in the VRMA
>
prev parent reply other threads:[~2011-07-27 4:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 4:15 [PATCH] powerpc: pseries: Fix kexec on machines with more than 4TB of RAM Anton Blanchard
2011-07-27 4:26 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2294.1311740770@neuling.org \
--to=mikey@neuling$(echo .)org \
--cc=anton@samba$(echo .)org \
--cc=kexec@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=miltonm@bga$(echo .)com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox