Subject: Re: [PATCH v1 01/12] powerpc/pseries: CMM: Implement release() function for sysfs device

From: David Hildenbrand <[email-masked]>
Date: Wed, 20 Nov 2019 11:35:37 +0100

On 14.11.19 10:08, Michael Ellerman wrote:
> On Thu, 2019-10-31 at 14:29:22 UTC, David Hildenbrand wrote:
>> When unloading the module, one gets
>> [  548.188594] ------------[ cut here ]------------
>> [  548.188596] Device 'cmm0' does not have a release() function, it is brok=
>> en and must be fixed. See Documentation/kobject.txt.
>> [  548.188622] WARNING: CPU: 0 PID: 19308 at drivers/base/core.c:1244 .devi=
>> ce_release+0xcc/0xf0
>> ...
>>
>> We only have on static fake device. There is nothing to do when
>> releasing the device (via cmm_exit).
>>
>> Cc: Benjamin Herrenschmidt <[email-masked]>
>> Cc: Paul Mackerras <[email-masked]>
>> Cc: Michael Ellerman <[email-masked]>
>> Cc: Andrew Morton <[email-masked]>
>> Cc: Vlastimil Babka <[email-masked]>
>> Cc: Konstantin Khlebnikov <[email-masked]>
>> Cc: Allison Randal <[email-masked]>
>> Cc: Greg Kroah-Hartman <[email-masked]>
>> Cc: Thomas Gleixner <[email-masked]>
>> Cc: Arun KS <[email-masked]>
>> Signed-off-by: David Hildenbrand <[email-masked]>
> 
> Patches 1-10 applied to powerpc next, thanks.
> 
> https://git.kernel.org/powerpc/c/7d8212747435c534c8d564fbef4541a463c976ff
> 
> cheers
> 

Hi Michael,

just to make sure you saw the two MM patches (and the ACKs from Michal)

https://lkml.org/lkml/2019/11/14/410

if you prefer that Andrew picks these up, please let me know.

Cheers!

-- 

Thanks,

David / dhildenb