Subject: Re: [PATCH 6/7] [POWERPC] booting-without-of: add FHCI USB, FSL MCU, FSL UPM and GPIO LEDs bindings

From: Segher Boessenkool <[email-masked]>
Date: Sat, 24 May 2008 00:10:56 +0200

> +      - fsl,fullspeed-clock : specifies the full speed USB clock 
> source in
> +        "clk<num>" or "brg<num>" format.
> +      - fsl,lowspeed-clock : specifies the low speed USB clock source 
> in
> +        "clk<num>" or "brg<num>" format.

What format is "<num>" in?

> +      - fsl,usb-mode : should be "host".

If that's the only possible value, this property is unnecessary,
no?  It probably would make sense to make this optional (and default
to "host") anyway.

> +      - linux,hub-power-budget : optional, USB power budget for the 
> root hub
> +        in mA.

Why is this linux-specific?

> +    w) Freescale MCU with MPC8349E-mITX compatible firmware
> +
> +    Required properties:
> +      - compatible : "fsl,<mcu-chip>-<board>", "fsl,mcu-mpc8349emitx";
> +      - reg : should specify I2C address (0x0a).
> +      - #address-cells : should be 0.
> +      - #size-cells : should be 0.

> +    x) Freescale Localbus UPM programmed to work with NAND flash

Similar here, except this one is never a GPIO controller.

If the point to have #a = #s = 0 is to not have a unit-address
in the child nodes: you should do that simply by not specifying
a "reg" in the child nodes.

> +    y) LEDs on GPIOs

This one is so full of "linux," stuff that I won't review it --
I wouldn't know where to start, sorry.

Segher