Subject: Re: [Patch next] powerpc: pseries/dtl.c should include asm/firmware.h

From: Michael Neuling <[email-masked]>
Date: Thu, 02 Apr 2009 11:34:03 +1100

> randconfig build on powerpc failed with :
> 
> 
> arch/powerpc/platforms/pseries/dtl.c: In function dtl_init:
> arch/powerpc/platforms/pseries/dtl.c:238: error: implicit declaration of func
tion firmware_has_feature
> arch/powerpc/platforms/pseries/dtl.c:238: error: FW_FEATURE_SPLPAR undeclared
 (first use in this function)
> arch/powerpc/platforms/pseries/dtl.c:238: error: (Each undeclared identifier 
is reported only once
> arch/powerpc/platforms/pseries/dtl.c:238: error: for each function it appears
 in.)
> 
> Signed-off-by : Sachin Sant <[email-masked]>
> ---

It's great that you're sending patches to fix these issues but it's not
quite formatted as the maintainers like.

The patch needs to be included inline in the message, rather than as an
attachment.  You can see it as an attachment here:
  http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070122.html
.. as opposed to the required inline format like this patch:
  http://ozlabs.org/pipermail/linuxppc-dev/2009-April/070120.html

Adding a diffstat would also be nice.

Mikey

> 
> 
> 
> --------------050404090408000502010008
> Content-Type: text/x-patch;
>  name="fix-dtl-build-break.patch"
> Content-Transfer-Encoding: 8bit
> Content-Disposition: inline;
>  filename="fix-dtl-build-break.patch"
> 
> * Fixes the following build error
> *
> * arch/powerpc/platforms/pseries/dtl.c: In function ‘dtl_init’:
> * arch/powerpc/platforms/pseries/dtl.c:238:
> *       error: implicit declaration of function ‘firmware_has_feature’
> * arch/powerpc/platforms/pseries/dtl.c:238:
> *       error: ‘FW_FEATURE_SPLPAR’ undeclared (first use in this function)
> * arch/powerpc/platforms/pseries/dtl.c:238:
> *        error: (Each undeclared identifier is reported only once
> * arch/powerpc/platforms/pseries/dtl.c:238: 
> *        error: for each function it appears in.)
> 
> Signed-off-by : Sachin Sant <[email-masked]>
> ---
> 
> diff -Naurp a/arch/powerpc/platforms/pseries/dtl.c b/arch/powerpc/platforms/p
series/dtl.c
> --- a/arch/powerpc/platforms/pseries/dtl.c	2009-04-01 15:46:59.000000000 +
0530
> +++ b/arch/powerpc/platforms/pseries/dtl.c	2009-04-01 15:47:58.000000000 +
0530
> @@ -25,6 +25,7 @@
>  #include <asm/smp.h>
>  #include <asm/system.h>
>  #include <asm/uaccess.h>
> +#include <asm/firmware.h>
>  
>  #include "plpar_wrappers.h"
>  
> 
> --------------050404090408000502010008
> Content-Type: text/plain; charset="us-ascii"
> MIME-Version: 1.0
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline
> 
> _______________________________________________
> Linuxppc-dev mailing list
> [email-masked]
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
> --------------050404090408000502010008--
>