Subject: Re: [PATCH 1/2] Maple: register CPC925 EDAC device on all boards with CPC925

From: Segher Boessenkool <[email-masked]>
Date: Sat, 21 May 2011 15:09:19 +0200

> Currently Maple setup code creates cpc925_edac device only on
> Motorola ATCA-6101 blade. Make setup code check bridge revision
> and enable EDAC on all U3 bridges.

But the EDAC code only works on U3H (CPC925), not old U3.

> +	if ((rev & 0xf0) != 0x30) { /* U3 */
> +		printk(KERN_ERR "%s: Non-CPC925(U3) bridge revision: %02x\n",

Should be:  if (rev >= 0x34 && rev <= 0x3f)

Segher