Subject: Re: [PATCH] PowerPC: usb ehci of_platform bindings for Sequoia 440EPx

From: Segher Boessenkool <[email-masked]>
Date: Fri, 14 Sep 2007 00:36:53 +0200

> EHCI OF bindings for PowerPC 440EPx Sequoia.

Those aren't bindings, they are examples.  Bindings are pieces
of documentation that describe what device-specific properties
mean what, what standard properties are required with what
values, etc.

Examples are good to have, of course.

One thing you really need to document is what "ehci-be-desc"
and friends mean.  I can give you one comment already: for
devices that are usually little-endian, but an implementation
implements registers as big-endian, precedent is to show that
in the device tree by including an (empty) "big-endian" property,
rather than inventing new "compatible" values.

Segher