From: Andrew Donnellan <ajd@linux•ibm.com>
To: Frederic Barrat <fbarrat@linux•ibm.com>,
linuxppc-dev@lists•ozlabs.org, clombard@linux•ibm.com
Cc: aik@ozlabs•ru, oohall@gmail•com, groug@kaod•org, alastair@au1•ibm.com
Subject: Re: [PATCH v2 01/11] powerpc/powernv/ioda: Fix ref count for devices with their own PE
Date: Thu, 9 Jan 2020 07:19:40 +1100 [thread overview]
Message-ID: <2fc70bbd-8e0e-4662-e143-d5a688a359d8@linux.ibm.com> (raw)
In-Reply-To: <449279e4-9c04-7933-41af-95d7a4928c45@linux.ibm.com>
On 9/1/20 1:11 am, Frederic Barrat wrote:
>> It took me a while to parse exactly what you're doing here.
>>
>> - In pnv_ioda_setup_dev_PE(), we take a reference on the pci_dev, this
>> is to protect a pointer in the pci_dn structure, but not to protect
>> the pointer in the pci_dev structure (which doesn't need to be
>> protected by taking a reference, because the lifetime of the
>> pnv_ioda_pe is the same as the pci_dev).
>>
>> - The pointer in the pci_dn structure has now been removed, so we
>> should remove the pci_dev_get() accordingly.
>
>
> Correct. Did I do such a bad job explaining it in the commit message
> that I need to rephrase?
I might just be a bit slow :)
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux•ibm.com IBM Australia Limited
next prev parent reply other threads:[~2020-01-08 20:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 13:49 [PATCH v2 00/11] opencapi: enable card reset and link retraining Frederic Barrat
2019-11-21 13:49 ` [PATCH v2 01/11] powerpc/powernv/ioda: Fix ref count for devices with their own PE Frederic Barrat
2020-01-08 7:33 ` Andrew Donnellan
2020-01-08 14:11 ` Frederic Barrat
2020-01-08 20:19 ` Andrew Donnellan [this message]
2020-01-29 5:17 ` Michael Ellerman
2019-11-21 13:49 ` [PATCH v2 02/11] powerpc/powernv/ioda: Protect PE list Frederic Barrat
2019-11-21 13:49 ` [PATCH v2 03/11] powerpc/powernv/ioda: set up PE on opencapi device when enabling Frederic Barrat
2019-11-21 13:49 ` [PATCH v2 04/11] powerpc/powernv/ioda: Release opencapi device Frederic Barrat
2019-11-22 5:22 ` Andrew Donnellan
2019-11-21 13:49 ` [PATCH v2 05/11] powerpc/powernv/ioda: Find opencapi slot for a device node Frederic Barrat
2019-11-22 4:27 ` Andrew Donnellan
2019-11-21 13:49 ` [PATCH v2 06/11] pci/hotplug/pnv-php: Remove erroneous warning Frederic Barrat
2019-11-21 13:49 ` [PATCH v2 07/11] pci/hotplug/pnv-php: Improve error msg on power state change failure Frederic Barrat
2019-11-21 13:49 ` [PATCH v2 08/11] pci/hotplug/pnv-php: Register opencapi slots Frederic Barrat
2019-11-22 4:33 ` Andrew Donnellan
2019-11-21 13:49 ` [PATCH v2 09/11] pci/hotplug/pnv-php: Relax check when disabling slot Frederic Barrat
2019-11-21 13:49 ` [PATCH v2 10/11] pci/hotplug/pnv-php: Wrap warnings in macro Frederic Barrat
2019-11-21 13:49 ` [PATCH v2 11/11] ocxl: Add PCI hotplug dependency to Kconfig Frederic Barrat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fc70bbd-8e0e-4662-e143-d5a688a359d8@linux.ibm.com \
--to=ajd@linux$(echo .)ibm.com \
--cc=aik@ozlabs$(echo .)ru \
--cc=alastair@au1$(echo .)ibm.com \
--cc=clombard@linux$(echo .)ibm.com \
--cc=fbarrat@linux$(echo .)ibm.com \
--cc=groug@kaod$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=oohall@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox