Subject: Re: Document and implement an improved flash device binding for powerpc (v5)

From: Segher Boessenkool <[email-masked]>
Date: Fri, 7 Sep 2007 16:25:10 +0200

> This patch replaces the binding for flash chips in
> booting-without-of.txt with an clarified and improved version.  It
> also makes drivers/mtd/maps/physmap_of.c recognize this new binding.
> Finally it revises the Ebony device tree source to use the new binding
> as an example.
>
> Signed-off-by: David Gibson <[email-masked]>

Acked-by: Segher Boessenkool <[email-masked]>

Thanks for doing this work David!

> +	/* First look for RedBoot table or partitions on the command
> +	 * line, these take precedence over device tree information */

Any specific reason you chose this order?  Just curious...

> +		.data		= (void *)"jedec_probe",

Hrm, this cast is only getting rid of the const-ness of the
string literal -- maybe .data should be declared const, or
does the majority of users want it writable?

Segher