From: Jiri Slaby <jirislaby@kernel•org>
To: Walt Drummond <walt@drummond•us>,
agordeev@linux•ibm.com, arnd@arndb•de, benh@kernel•crashing.org,
borntraeger@de•ibm.com, chris@zankel•net, davem@davemloft•net,
gregkh@linuxfoundation•org, hca@linux•ibm.com, deller@gmx•de,
ink@jurassic•park.msu.ru, James.Bottomley@HansenPartnership•com,
mattst88@gmail•com, jcmvbkbc@gmail•com, mpe@ellerman•id.au,
paulus@samba•org, rth@twiddle•net, dalias@libc•org,
tsbogend@alpha•franken.de, gor@linux•ibm.com,
ysato@users•osdn.me
Cc: linux-arch@vger•kernel.org, linux-s390@vger•kernel.org,
linux-ia64@vger•kernel.org, linux-parisc@vger•kernel.org,
linux-sh@vger•kernel.org, linux-xtensa@linux-xtensa•org,
linux-mips@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-alpha@vger•kernel.org, sparclinux@vger•kernel.org,
ar@cs•msu.ru, linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2 3/3] vstatus: Display an informational message when the VSTATUS character is pressed or TIOCSTAT ioctl is called.
Date: Mon, 7 Feb 2022 06:38:16 +0100 [thread overview]
Message-ID: <35f29dbd-04ec-037e-007c-7a079caf0d5b@kernel.org> (raw)
In-Reply-To: <20220206154856.2355838-4-walt@drummond.us>
On 06. 02. 22, 16:48, Walt Drummond wrote:
> When triggered by pressing the VSTATUS key or calling the TIOCSTAT
> ioctl, the n_tty line discipline will display a message on the user's
> tty that provides basic information about the system and an
> 'interesting' process in the current foreground process group, eg:
>
> load: 0.58 cmd: sleep 744474 [sleeping] 0.36r 0.00u 0.00s 0% 772k
>
> The status message provides:
> - System load average
> - Command name and process id (from the perspective of the session)
> - Scheduler state
> - Total wall-clock run time
> - User space run time
> - System space run time
> - Percentage of on-cpu time
> - Resident set size
>
> The message is only displayed when the tty has the VSTATUS character
> set, the local flags ICANON and IEXTEN are enabled and NOKERNINFO is
> disabled; it is always displayed when TIOCSTAT is called regardless of
> tty settings.
>
> Signed-off-by: Walt Drummond <walt@drummond•us>
> ---
It looks like my comments were addressed. However you did not document
the chances since v1 here. IOW, [v2] tag missing here.
And please add the CCs I added last time, so that relevant people still
can comment.
thanks,
--
js
suse labs
prev parent reply other threads:[~2022-02-07 5:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 15:48 [PATCH v2 0/3] vstatus: TTY status message request Walt Drummond
2022-02-06 15:48 ` [PATCH v2 1/3] vstatus: Allow the n_tty line dicipline to write to a user tty Walt Drummond
2022-02-06 15:48 ` [PATCH v2 2/3] status: Add user space API definitions for VSTATUS, NOKERNINFO and TIOCSTAT Walt Drummond
2022-02-06 17:09 ` Greg KH
2022-02-06 15:48 ` [PATCH v2 3/3] vstatus: Display an informational message when the VSTATUS character is pressed or TIOCSTAT ioctl is called Walt Drummond
2022-02-06 17:16 ` Greg KH
2022-02-06 21:25 ` Arseny Maslennikov
2022-02-06 22:44 ` Arseny Maslennikov
2022-02-07 5:38 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35f29dbd-04ec-037e-007c-7a079caf0d5b@kernel.org \
--to=jirislaby@kernel$(echo .)org \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=agordeev@linux$(echo .)ibm.com \
--cc=ar@cs$(echo .)msu.ru \
--cc=arnd@arndb$(echo .)de \
--cc=benh@kernel$(echo .)crashing.org \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=chris@zankel$(echo .)net \
--cc=dalias@libc$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=gor@linux$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hca@linux$(echo .)ibm.com \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mattst88@gmail$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
--cc=rth@twiddle$(echo .)net \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=walt@drummond$(echo .)us \
--cc=ysato@users$(echo .)osdn.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox