* Possible bug in CPM interrupt handling
@ 2000-10-12 13:35 Ian Abbott
2000-10-12 16:53 ` Dan Malek
0 siblings, 1 reply; 2+ messages in thread
From: Ian Abbott @ 2000-10-12 13:35 UTC (permalink / raw)
To: 'linuxppc-embedded@lists•linuxppc.org'
In function cpm_interrupt (commproc.c), the last line is:
((immap_t *)IMAP_ADDR)->im_cpic.cpic_cisr |= (1 << vec);
I think this should be:
((immap_t *)IMAP_ADDR)->im_cpic.cpic_cisr = (1 << vec);
If there are nested interrupts (are these allowed?) this makes sure
only the specific interrupt we are dealing with is acknowledged.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev•co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Possible bug in CPM interrupt handling
2000-10-12 13:35 Possible bug in CPM interrupt handling Ian Abbott
@ 2000-10-12 16:53 ` Dan Malek
0 siblings, 0 replies; 2+ messages in thread
From: Dan Malek @ 2000-10-12 16:53 UTC (permalink / raw)
To: Ian Abbott; +Cc: 'linuxppc-embedded@lists•linuxppc.org'
Ian Abbott wrote:
>
> In function cpm_interrupt (commproc.c), the last line is:
>
> ((immap_t *)IMAP_ADDR)->im_cpic.cpic_cisr |= (1 << vec);
Oh crap, it that _still_ there? Yes, you are correct, and I don't
know why I can't make this modification stick. I'm going to push
it into the 2.4 BK tree right now.......
> If there are nested interrupts (are these allowed?) this makes sure
> only the specific interrupt we are dealing with is acknowledged.
Yes, they are allowed and this is a bug. Thanks.
-- Dan
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2000-10-12 16:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2000-10-12 13:35 Possible bug in CPM interrupt handling Ian Abbott
2000-10-12 16:53 ` Dan Malek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox