public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed

From: "Sébastien Côté" <scote1@matrox•com>
To: linuxppc-dev@lists•linuxppc.org
Subject: why XOR ext2_set_bit?
Date: Wed, 14 Mar 2001 17:28:36 -0500	[thread overview]
Message-ID: <3AAFF094.6137F71A@matrox.com> (raw)


Hi,

I just had a problem writing to a file on a ext2 filesystem with my port
of kernel 2.4 on powerpc (G4) running in little-endian.  When the
function ext2_set_bit was called by ext2_new_block, it returned
something so I got the warning :

"ext2_new_block bit already set for block 161"

and I was stuck in an infinite loop.  I found the definition for the
function in include/asm-ppc/bitops.h as follow:

#define ext2_set_bit(nr, addr)		test_and_set_bit((nr) ^ 0x18, addr)

Now my question:  Why is "nr" XORed with 0x18 ???  I tried to do this
function on paper and with this XOR, they were always trying to change
the wrong bit.  Now, since nobody's been reporting this problem before,
I guess this XOR is ok but I'd really like to understand it's utility to
correct things on my side (for now, I just removed it and everything
appears to be fine).

Could someone give me an explanation?

Thanks,

Sébastien Côté

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

next             reply	other threads:[~2001-03-14 22:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-14 22:28 Sébastien Côté [this message]
2001-03-15  8:30 ` why XOR ext2_set_bit? Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3AAFF094.6137F71A@matrox.com \
    --to=scote1@matrox$(echo .)com \
    --cc=linuxppc-dev@lists$(echo .)linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox