public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k•org>
To: Armin Kuster <akuster@mvista•com>
Cc: ppcdevel <linuxppc-dev@lists•linuxppc.org>
Subject: Re: New API for non cache coherent ppc cpu's
Date: Wed, 21 Nov 2001 21:20:24 +0100	[thread overview]
Message-ID: <3BFC0C87.30658419@linux-m68k.org> (raw)
In-Reply-To: 3BFBF277.A05245D6@mvista.com


Hi,

Armin Kuster wrote:

> mapping = pci_map_page(pdev,
>                                virt_to_page(cmd->request_buffer),

This is the problem, virt_to_page doesn't work kmap'ed highmem pages.

> > - I think it was never defined, what should be done if offset/size isn't
> > cache line aligned. That's especially a problem in the invalidate only
> > case. I'd prefer to make this illegal, as it's mostly not a problem for
> > drivers.
>
> wouldn't it also be a problem for consistent_sync?  we don't check for
> offset/size are cache line aligned.

Yes, same problem.

bye, Roman

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

  reply	other threads:[~2001-11-21 20:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-20 20:13 New API for non cache coherent ppc cpu's Armin Kuster
2001-11-21 11:15 ` Roman Zippel
2001-11-21 18:29   ` Armin Kuster
2001-11-21 20:20     ` Roman Zippel [this message]
2001-11-22 20:57 ` Paul Mackerras
2001-11-22 23:07   ` Dan Malek
2001-11-22 23:54     ` Roman Zippel
2001-11-23  1:32     ` Paul Mackerras
2001-11-23 16:08       ` Dan Malek
2001-11-22 23:50   ` Roman Zippel
2001-11-23  1:09     ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3BFC0C87.30658419@linux-m68k.org \
    --to=zippel@linux-m68k$(echo .)org \
    --cc=akuster@mvista$(echo .)com \
    --cc=linuxppc-dev@lists$(echo .)linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox