From: Mathias von Essen <matthias.vonessen@metagmbh•de>
To: hollis@austin•ibm.com
Cc: linuxppc-dev <linuxppc-dev@lists•linuxppc.org>,
Sven Dickert <Sven.Dickert@planb•de>
Subject: Re: patch: i8259.c & PCI int ack
Date: Thu, 06 Dec 2001 15:00:09 +0100 [thread overview]
Message-ID: <3C0F79E9.B66D34B6@metagmbh.de> (raw)
In-Reply-To: 20011204094600.K421@austin.ibm.com
hollis@austin•ibm.com wrote:
>
> On Mon, Dec 03, 2001 at 04:09:23PM -0600, hollis@austin•ibm.com wrote:
> >
> > - i8259_irq has been renamed to i8259_poll
> > - a new i8259_irq has been added, which uses the PCI int ack address
> > - both i8259_irq and i8259_poll are no longer passed the unused 'int cpu'
> > - i8259_init now takes a 'long intack_addr', which on PReP is 0xbffffff0.
> > For platforms that only poll, this argument is irrelevant and can be 0x0
> > - IO resources 0x20-0x21, 0xA0-0xA1, and 0x4D0-0x4D1 are now reserved
> > - ISR selection is done once at initialization rather than on every irq
> >
> > This patch works on my (PReP) PowerSeries 830 and fixes the interrupt death
> > problems I and others have seen.
> >
> > If this is the right idea, I intend to change all 8259 users:
> > - ppc_md.get_irq = i8259_irq -> ppc_md.get_irq = i8259_poll
> > - i8259_init() -> i8259_init(0x0)
> > - i8259_irq(smp_processor_id()) -> i8259_poll()
>
> Here is the complete patch. I have not compile-tested all N embedded targets.
> The only arch actually using i8259_irq (rather than i8259_poll) right now is
> PReP. From the last 8259 thread, I think all current boards *could* use it if
> they wanted to.
>
> I noticed that quite a few boards have code like this:
> /* Resolves the open_pic.c build without including i8259.c */
> int i8259_irq(int cpu)
> {
> return 0;
> }
> That and the #ifndef CONFIG_GEMINI (maybe Gemini should have a dummy function
> too to remove #ifdefs) suggests there's something wrong with open_pic.c, but I
> guess everyone already knows that.
>
> -Hollis
Works great on my IBM 40P. I needed some time to change the patch to
stock 2.4.16
which I use here. CS4232 sound, eth0 and ncr scsi working simultanously
with no
irq problems.
TNX
mathias
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2001-12-06 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-03 22:09 RFC: i8259.c & PCI int ack hollis
2001-12-04 15:46 ` patch: " hollis
2001-12-04 16:29 ` hollis
2001-12-06 14:00 ` Mathias von Essen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C0F79E9.B66D34B6@metagmbh.de \
--to=matthias.vonessen@metagmbh$(echo .)de \
--cc=Sven.Dickert@planb$(echo .)de \
--cc=hollis@austin$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox