From: "Mark A. Greer" <mgreer@mvista•com>
To: Michael Sokolov <msokolov@ivan•Harhan.ORG>
Cc: linux-galileo@source•mvista.com, linuxppc-dev@lists•linuxppc.org
Subject: Re: [Linux-galileo] ev64260 bi_rec patch
Date: Fri, 29 Mar 2002 17:24:11 -0500 [thread overview]
Message-ID: <3CA4E98B.F7A7ECE0@mvista.com> (raw)
In-Reply-To: 0203292359.AA12953@ivan.Harhan.ORG
Michael Sokolov wrote:
> Mark A. Greer <mgreer@mvista•com> wrote:
>
> > I have other things to do so I won't be able to finish today. In case
> > someone wants to work on this over the weekend, attached is a patch of
> > what I have so far. It implements the example bi_rec's emailed before
> > for the ev64260 board. Feel free to use it or do a better job.
>
> Looks OK except for 2 major problems:
>
> 1. You are using find_bootinfo() in EV-64260 platform_init to find the bi_recs.
> This is bad, as the magic location where find_bootinfo looks for the bi_recs is
> unavailable to bootloaders outside the linux source tree. Instead I have
> adopted the convention (which Tom Rini has accepted for the K2 port and
> implemented in the wrapper) to pass the physical address of bi_recs to the
> kernel in R3. You should use r3 + KERNELBASE in platform_init to find the
> bi_recs. This works with the wrapper just as well as find_bootinfo(), but is
> much nicer for external bootloaders.
It *is* in the kernel source (and not the bootloader). Also, 15 of the *_setup.c
files in arch/ppc/platforms call find_bootinfo including ev64260_setup.c before I
modified it. I think the R3 way of doing things is out of date now but maybe Tom
can elaborate.
> 2. You are also using find_bootinfo() in the gt64260_eth driver to find its
> bi_recs. In addition to the problems mentioned above, this has the extra
> problem in that find_bootinfo's magic location, or any other bootloader's
> location for that matter, has certainly been overwritten at this point. If you
> want to peek at bi_recs after platform_init(), you have to have setup.c or
> something copy them into memory that the kernel will retain.
>
> Because of problem #2 your code will most certainly not work as it is right
> now.
You may have a point here. I thought the bi_rec's were left around but I need to
verify.
Mark
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-03-29 22:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-29 23:59 [Linux-galileo] ev64260 bi_rec patch Michael Sokolov
2002-03-29 22:24 ` Mark A. Greer [this message]
2002-03-29 22:30 ` Mark A. Greer
2002-03-29 22:41 ` Mark A. Greer
2002-03-30 0:45 ` Michael Sokolov
2002-04-01 15:20 ` Tom Rini
2002-04-01 15:25 ` Tom Rini
2002-04-01 15:09 ` Mark A. Greer
2002-04-01 18:53 ` Tom Rini
2002-04-01 19:52 ` Michael Sokolov
2002-04-01 20:21 ` Tom Rini
2002-04-02 2:38 ` Paul Mackerras
2002-04-02 2:50 ` Paul Mackerras
-- strict thread matches above, loose matches on Subject: below --
2002-03-30 0:42 Michael Sokolov
2002-04-01 19:31 Michael Sokolov
2002-04-01 18:03 ` Mark A. Greer
2002-04-01 20:09 Michael Sokolov
2002-04-02 3:35 Michael Sokolov
2002-04-03 5:09 ` Troy Benjegerdes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CA4E98B.F7A7ECE0@mvista.com \
--to=mgreer@mvista$(echo .)com \
--cc=linux-galileo@source$(echo .)mvista.com \
--cc=linuxppc-dev@lists$(echo .)linuxppc.org \
--cc=msokolov@ivan$(echo .)Harhan.ORG \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox