From: "Mark A. Greer" <mgreer@mvista•com>
To: Michael Sokolov <msokolov@ivan•Harhan.ORG>
Cc: linuxppc-dev@lists•linuxppc.org
Subject: Re: CONFIG_GENERIC_PPC32
Date: Thu, 11 Apr 2002 15:10:21 -0400 [thread overview]
Message-ID: <3CB5DF9D.55A3EF95@mvista.com> (raw)
In-Reply-To: 0204112051.AA29511@ivan.Harhan.ORG
Michael Sokolov wrote:
> I have replaced gt64260_common.c with gt64260_data.c and gt64260_utils.c so
> that one can choose to use the utility functions for non-OF non-StarMON boards
> or not use them for good OF/StarMON, but still always have the crucial global
> variables.
>
> <snip>
>
> Then fine, keep that library and use it for your ports to your heart's delight.
> Just please let HEC ports not use it.
You never _had_ to use the gt64260_common code if you didn't want to. Its just a
library of stuff there to be used (but I would expect most if not all boards with a
gt64260 to use many of the functions in it). If you don't want to, that's fine.
My issue is that your gt64260_utils.c doesn't have a lot of functionality that
_common.c does.
I guess I still don't know what you want. Do you want your _data.c and _utils.c pushed
too or instead of _common.c? Either way, why not use the functions that are already in
_common.c instead? If that functionality isn't there, add it. If its the size of
gt64260_common.c, then it can be broken up. I would already like to move the
find_bridges, bridge_init, and check_errata routines into their own file. Doesn't
reduce the size that much but it splits it up a little so you can not link the .o file
with find_bridges, etc code if you don't want it, for example.
Mark
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-04-11 19:10 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-11 20:51 CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-11 19:10 ` Mark A. Greer [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-04-11 17:15 CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-11 16:24 CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-11 16:50 ` CONFIG_GENERIC_PPC32 benh
2002-04-11 15:40 CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-11 15:49 ` CONFIG_GENERIC_PPC32 Geert Uytterhoeven
2002-04-11 16:13 ` CONFIG_GENERIC_PPC32 benh
2002-04-11 3:08 CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-10 23:42 ` CONFIG_GENERIC_PPC32 Benjamin Herrenschmidt
2002-04-11 17:51 ` CONFIG_GENERIC_PPC32 Mark A. Greer
2002-04-12 12:57 ` CONFIG_GENERIC_PPC32 Paul Mackerras
2002-04-12 11:57 ` CONFIG_GENERIC_PPC32 benh
2002-04-12 19:02 ` CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-15 15:46 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-15 18:08 ` CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-15 19:54 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-06 22:17 CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-06 23:29 ` CONFIG_GENERIC_PPC32 Benjamin Herrenschmidt
2002-04-06 21:39 CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-06 22:52 ` CONFIG_GENERIC_PPC32 Benjamin Herrenschmidt
2002-04-07 8:34 ` CONFIG_GENERIC_PPC32 Geert Uytterhoeven
2002-04-07 9:04 ` CONFIG_GENERIC_PPC32 Benjamin Herrenschmidt
2002-04-09 8:12 ` CONFIG_GENERIC_PPC32 Michael Schmitz
2002-04-06 20:23 CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-06 22:06 ` CONFIG_GENERIC_PPC32 Benjamin Herrenschmidt
2002-04-08 15:48 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-08 16:03 ` CONFIG_GENERIC_PPC32 Gabriel Paubert
2002-04-08 16:24 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-08 16:48 ` CONFIG_GENERIC_PPC32 Gabriel Paubert
2002-04-08 17:23 ` CONFIG_GENERIC_PPC32 Matt Porter
2002-04-08 17:37 ` CONFIG_GENERIC_PPC32 Gabriel Paubert
2002-04-08 18:07 ` CONFIG_GENERIC_PPC32 Matt Porter
2002-04-08 18:41 ` CONFIG_GENERIC_PPC32 Gabriel Paubert
2002-04-08 18:18 ` CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-08 18:53 ` CONFIG_GENERIC_PPC32 Matt Porter
2002-04-09 14:59 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-09 19:52 ` CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-10 8:27 ` CONFIG_GENERIC_PPC32 Geert Uytterhoeven
2002-04-10 15:17 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-11 3:50 ` CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-11 15:27 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-10 15:16 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-11 3:46 ` CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-11 15:24 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-11 16:16 ` CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-11 15:51 ` CONFIG_GENERIC_PPC32 Mark A. Greer
2002-04-11 16:59 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-11 17:25 ` CONFIG_GENERIC_PPC32 Michael Sokolov
2002-04-11 17:42 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-10 19:08 ` CONFIG_GENERIC_PPC32 Tom Rini
2002-04-10 13:20 ` CONFIG_GENERIC_PPC32 Paul Mackerras
2002-04-10 15:23 ` CONFIG_GENERIC_PPC32 benh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CB5DF9D.55A3EF95@mvista.com \
--to=mgreer@mvista$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)linuxppc.org \
--cc=msokolov@ivan$(echo .)Harhan.ORG \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox