public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
* Variable name inconsistancies / resources on building patches
@ 2002-04-12 23:41 Kevin Fry
  0 siblings, 0 replies; only message in thread
From: Kevin Fry @ 2002-04-12 23:41 UTC (permalink / raw)
  To: linuxppc emb3dd3d list


Looking at 2.4.18, I see that the the variable in immap_8260.h  for the
SCC's Protocol-Specific Mode Register is called the scc_pmsr. All the
#defines for it are called SCC_PMSR_blah.

As you can see someone called it the pmsr instead of the psmr which it
should be. All of the code for the FCC's uses the correct acronym
however..

The code I look at and compile all uses the correct (incorrect) name for
the SCC PSMR, so should we bother to write a patch to fix this?  I'm
inclined to say yes, only because it's frustrating to me to program
drivers and such with incorrect names :)

Since this would be my first kernel patch, are there any resources on
how to build patches and against what, and who to submit em
too??? thanks!

Kevin Fry


** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-04-12 23:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-04-12 23:41 Variable name inconsistancies / resources on building patches Kevin Fry

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox