From: Armin Kuster <akuster@mvista•com>
To: David Gibson <david@gibson•dropbear.id.au>
Cc: linuxppc-embedded@lists•linuxppc.org, Paul Mackerras <paulus@samba•org>
Subject: Re: Another OCP enet patch
Date: Sun, 26 May 2002 23:14:28 -0700 [thread overview]
Message-ID: <3CF1CEC4.1020205@mvista.com> (raw)
In-Reply-To: 20020527040330.GH16537@zax
David Gibson wrote:
> Armin, please consider the patch below. It removes your recently
> added ocp-dma.h and instead makes the ocp enet driver uses the DMA
> direction constants from pci.h.
Go ahead and push it. FYI - I will update the ocp ide driver since I am
making changes in it any ways.
>
> I realise that logically the OCP enet driver, and the
> consistent_sync() has nothing to do with PCI. However using the pci.h
> constants seems a better approach than defining new constants with the
> same values, when the switch in consistent_sync() explicitly checks
> against the PCI constants.
>
> In the longer term consistent_sync() itself should be changed not to
> reference the PCI constants - in fact the PCI constants should
> probably be moved and renamed since they have no inherent connection
> with PCI at all.
I have already had to make that break with the ocp usb driver. If a 4xx
core shows up with PCI and ocp ide or ocp USB then we will need to
address this issue. thus those dma APIs I sent you are a result of my
concern.
>
> Oh, I also change the consistent_sync() in the Tx routine to be
> PCI_DMA_TODEVICE rather than BIDIRECTIONAL, since there is no need to
> invalidate the cache here, a writeback is all that's necessary.
>
>
Thanks
armin
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2002-05-27 6:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-27 4:03 Another OCP enet patch David Gibson
2002-05-27 6:14 ` Armin Kuster [this message]
2002-05-27 16:23 ` Tom Rini
2002-05-28 0:57 ` David Gibson
2002-05-28 1:25 ` Tom Rini
2002-05-28 6:36 ` David Gibson
2002-05-28 15:08 ` Tom Rini
2002-05-28 7:02 ` Armin
2002-05-28 6:50 ` David Gibson
2002-05-28 10:51 ` Dan Malek
2002-05-29 3:48 ` David Gibson
2002-05-29 14:51 ` Dan Malek
2002-05-28 10:39 ` Dan Malek
2002-05-29 4:16 ` David Gibson
2002-05-29 15:02 ` Dan Malek
2002-05-29 16:01 ` Armin Kuster
2002-05-30 3:10 ` David Gibson
2002-05-30 3:09 ` David Gibson
2002-05-30 4:16 ` Dan Malek
2002-05-30 4:30 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CF1CEC4.1020205@mvista.com \
--to=akuster@mvista$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-embedded@lists$(echo .)linuxppc.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox