Subject: Re: Question about ppc4xx_dma.h

From: Todd Poynor <[email-masked]>
Date: Wed, 21 Aug 2002 15:17:42 -0700

Noticed that the order of clearing the old transfer mode bits and
setting the p_dma_ch->mode bits is reversed in the new patch, not sure
if this causes problems:

+       tmp_cntl |= (p_dma_ch->mode | DMA_CH_ENABLE);
+
+       switch (dmanr) {
+       case 0:
+               control = mfdcr(DCRN_DMACR0);
+               control |= tmp_cntl;
+               control &= ~(DMA_TM_MASK | DMA_TD);     /* clear all
mode bits */

This seems to set and then clear the p_dma_ch->mode bits in control
prior to writing to the DMACR, a problem?

--
Todd

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/