Subject: Re: FCC patch..really

From: Dan Malek <[email-masked]>
Date: Tue, 27 Aug 2002 23:52:36 -0400

Allen Curtis wrote:

> +    if [ "$CONFIG_FCC1_ENET" = "y" ]; then
> +      choice 'RX Clk Source'	\

Please don't do this.......it doesn't belong in the configuration
file.  There are more things unique to a board configuration than
the clock routing.  This belongs as a structure in a C file, selectable
by board type (along with other board specific selections).

Thanks.

	-- Dan

** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/