From: Pantelis Antoniou <panto@intracom•gr>
To: Paul Mackerras <paulus@samba•org>
Cc: linuxppc-embedded@lists•linuxppc.org
Subject: Re: New style dpalloc/hostalloc routines (diff).
Date: Fri, 20 Dec 2002 11:57:24 +0200 [thread overview]
Message-ID: <3E02E984.8090904@intracom.gr> (raw)
In-Reply-To: <15874.23846.177956.192840@argo.ozlabs.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1527 bytes --]
Paul Mackerras wrote:
>Pantelis Antoniou writes:
>
>
>
>>+# Support new type of routines, usable from modules
>>+bool 'Use new type dpalloc routines()' CONFIG_NEW_DPALLOC
>>+bool 'Use new type hostalloc routines()' CONFIG_NEW_HOSTALLOC
>>+if [ "$CONFIG_NEW_DPALLOC" = "y" -o "$CONFIG_NEW_HOSTALLOC" = "y" ]; then
>>+ define_bool CONFIG_CPM_RHEAP y
>>+fi
>>
>>
>
>I don't want to see config options that select between different
>internal implementations of the same thing. Either your new routines
>are better, and we'll use them, or they are worse, and we'll use the
>old ones. Having a config option just leads to tons of ifdefs
>throughout the code, which makes it harder to read and understand.
>Having two implementations of the same thing is just bloat.
>
>Similarly, I don't like the way all your new routines have a "new_"
>prefix on the name. You should be thinking of replacing the existing
>routines rather than providing an alternative implementation with a
>different name. Where you have changed the API, either fix the
>drivers or provide a compatibility routine.
>
>The way it looks at the moment, it seems that you don't really have
>the conviction that your code is better than what is there already.
>Please redo your patch so that it just replaces the old routines. And
>please don't send it as a bkpatch since they are impossible to read, a
>plain diff -u is much better.
>
>Paul.
>
>
>
>
>
>
OK
Here is the updated patch in diff format as per your suggestions.
Any more suggestions?
Pantelis
[-- Attachment #2: linuxppc_2_4_devel-dpalloc.patch.gz --]
[-- Type: application/x-gunzip, Size: 8109 bytes --]
next prev parent reply other threads:[~2002-12-20 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-18 12:39 New style dpalloc/hostalloc routines (diff) Pantelis Antoniou
2002-12-19 23:58 ` Paul Mackerras
2002-12-20 8:09 ` Pantelis Antoniou
2002-12-20 9:57 ` Pantelis Antoniou [this message]
2002-12-23 16:49 ` Tom Rini
2002-12-23 20:07 ` Dan Malek
2003-01-20 0:31 ` Tom Rini
2002-12-24 7:01 ` Pantelis Antoniou
2002-12-24 14:25 ` Tom Rini
-- strict thread matches above, loose matches on Subject: below --
2002-12-18 12:38 Pantelis Antoniou
2002-12-18 12:51 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E02E984.8090904@intracom.gr \
--to=panto@intracom$(echo .)gr \
--cc=linuxppc-embedded@lists$(echo .)linuxppc.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox