From: Michael Ellerman <mpe@ellerman•id.au>
To: Alexey Kardashevskiy <aik@ozlabs•ru>, linuxppc-dev@lists•ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs•ru>,
Alistair Popple <alistair@popple•id.au>,
Paul Mackerras <paulus@samba•org>,
Gavin Shan <gwshan@linux•vnet.ibm.com>
Subject: Re: [kernel,1/2] powerpc/powernv: Fix insufficient memory allocation
Date: Thu, 12 May 2016 21:32:42 +1000 (AEST) [thread overview]
Message-ID: <3r59p252j6z9t7V@ozlabs.org> (raw)
In-Reply-To: <1463032030-38974-2-git-send-email-aik@ozlabs.ru>
On Thu, 2016-12-05 at 05:47:09 UTC, Alexey Kardashevskiy wrote:
> The pnv_pci_init_ioda_phb() helper allocates a blob to store auxilary
> data such PE and M32/M64 segment allocation maps; this single blob has few
> partitions, size of each is derived from the PE number -
> phb->ioda.total_pe_num.
>
> It was assumed that the minimum PE number is 8, however it is 4 for NPU
> so the pe_alloc part was missing in the allocated blob.
> It was invisible till recently as we were not tracking used M64 segments
> and NPUs do not use M32 segments so the phb->ioda.m32_segmap
> (which was pointing to the same address as phb->ioda.pe_alloc)
> has never been written to leaving the pe_alloc memory intact.
>
> After 401203ac2d "powerpc/powernv: Track M64 segment consumption"
> the pe_alloc gets corrupted and PE allocation cannot work.
> This fixes the issue by enforcing the minimum PE number to 8.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs•ru>
> Reviewed-by: Gavin Shan <gwshan@linux•vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/92a86756904b127a3450262b33
cheers
next prev parent reply other threads:[~2016-05-12 11:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 5:47 [PATCH kernel 0/2] powerpc/powernv/npu: Fixes for next tree Alexey Kardashevskiy
2016-05-12 5:47 ` [PATCH kernel 1/2] powerpc/powernv: Fix insufficient memory allocation Alexey Kardashevskiy
2016-05-12 6:09 ` Gavin Shan
2016-05-12 6:39 ` Alexey Kardashevskiy
2016-05-12 6:59 ` Gavin Shan
2016-05-12 11:32 ` Michael Ellerman [this message]
2016-05-12 5:47 ` [PATCH kernel 2/2] powerpc/powernv/npu: Add PE to PHB's list Alexey Kardashevskiy
2016-05-12 6:15 ` Gavin Shan
2016-05-12 11:32 ` [kernel,2/2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3r59p252j6z9t7V@ozlabs.org \
--to=mpe@ellerman$(echo .)id.au \
--cc=aik@ozlabs$(echo .)ru \
--cc=alistair@popple$(echo .)id.au \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox