From: Michael Ellerman <mpe@ellerman•id.au>
To: Ian Munsie <imunsie@au1•ibm.com>, mikey <mikey@neuling•org>,
linuxppc-dev@lists•ozlabs.org,
Frederic Barrat <frederic.barrat@fr•ibm.com>,
Huy Nguyen <huyn@mellanox•com>
Cc: Ian Munsie <imunsie@au1•ibm.com>
Subject: Re: [2/2] cxl: Fix allocating a minimum of 2 pages for the SPA
Date: Mon, 11 Jul 2016 20:19:22 +1000 (AEST) [thread overview]
Message-ID: <3rp1Kk4Pgcz9t14@ozlabs.org> (raw)
In-Reply-To: <1467202586-13412-2-git-send-email-imunsie@au.ibm.com>
On Wed, 2016-29-06 at 12:16:26 UTC, Ian Munsie wrote:
> From: Ian Munsie <imunsie@au1•ibm.com>
>
> The Scheduled Process Area is allocated dynamically with enough pages to
> fit at least as many processes as the AFU descriptor indicated. Since
> the calculation is non-trivial, it does this by calculating how many
> processes could fit in an allocation of a given order, and increasing
> that order until it can fit enough processes or hits the maximum
> supported size.
>
> Currently, it will start this search using a SPA of 2 pages instead of
> 1. This can waste a page of memory if the AFU's maximum number of
> supported processes was small enough to fit in one page.
>
> Fix the algorithm to start the search at 1 page.
>
> Signed-off-by: Ian Munsie <imunsie@au1•ibm.com>
> Reviewed-by: Frederic Barrat <fbarrat@linux•vnet.ibm.com>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1•ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/2224b6719b09052a9fbf29422a
cheers
next prev parent reply other threads:[~2016-07-11 10:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 12:16 [PATCH 1/2] cxl: Fix allowing bogus AFU descriptors with 0 maximum processes Ian Munsie
2016-06-29 12:16 ` [PATCH 2/2] cxl: Fix allocating a minimum of 2 pages for the SPA Ian Munsie
2016-06-29 16:06 ` Frederic Barrat
2016-06-29 23:07 ` Andrew Donnellan
2016-07-11 10:19 ` Michael Ellerman [this message]
2016-06-29 16:06 ` [PATCH 1/2] cxl: Fix allowing bogus AFU descriptors with 0 maximum processes Frederic Barrat
2016-06-29 22:35 ` Andrew Donnellan
2016-07-11 10:19 ` [1/2] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3rp1Kk4Pgcz9t14@ozlabs.org \
--to=mpe@ellerman$(echo .)id.au \
--cc=frederic.barrat@fr$(echo .)ibm.com \
--cc=huyn@mellanox$(echo .)com \
--cc=imunsie@au1$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mikey@neuling$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox