From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Alexey Kardashevskiy <aik@ozlabs•ru>, linuxppc-dev@lists•ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs•ru>,
#@ozlabs.ru, 4.2+@ozlabs•ru, stable@vger•kernel.org,
David Gibson <david@gibson•dropbear.id.au>
Subject: Re: [kernel] powerpc/powernv/ioda: Fix endianness when reading TCEs
Date: Fri, 22 Jul 2016 15:50:43 +1000 (AEST) [thread overview]
Message-ID: <3rwfrg3pBPz9t0w@ozlabs.org> (raw)
In-Reply-To: <1468988811-49142-1-git-send-email-aik@ozlabs.ru>
On Wed, 2016-20-07 at 04:26:51 UTC, Alexey Kardashevskiy wrote:
> The iommu_table_ops::exchange() callback writes new TCE to the table
> and returns old value and permission mask. The old TCE value is
> correctly converted from BE to CPU endian; however permission mask
> was calculated from BE value and therefore always returned DMA_NONE
> which could cause memory leak on LE systems using VFIO SPAPR TCE IOMMU v1
> driver.
>
> This fixes pnv_tce_xchg() to have @oldtce a CPU endian.
>
> Fixes: 05c6cfb9dce0d13d37e9d007ee6a4af36f1c0a58
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs•ru>
> Reviewed-by: David Gibson <david@gibson•dropbear.id.au>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/802a345183c0308aa64969cca6
cheers
prev parent reply other threads:[~2016-07-22 5:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 4:26 [PATCH kernel] powerpc/powernv/ioda: Fix endianness when reading TCEs Alexey Kardashevskiy
2016-07-20 9:16 ` David Gibson
2016-07-22 5:50 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3rwfrg3pBPz9t0w@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=#@ozlabs.ru \
--cc=4.2+@ozlabs$(echo .)ru \
--cc=aik@ozlabs$(echo .)ru \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox