From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: powerpc/xics: Properly set Edge/Level type and enable resend
Date: Tue, 9 Aug 2016 21:26:45 +1000 (AEST) [thread overview]
Message-ID: <3s7sS54c6Mz9t23@ozlabs.org> (raw)
In-Reply-To: <1470105583.12584.5.camel@kernel.crashing.org>
On Tue, 2016-02-08 at 02:39:43 UTC, Benjamin Herrenschmidt wrote:
> This sets the type of the interrupt appropriately. We set it as follow:
>
> - If not mapped from the device-tree, we use edge. This is the case
> of the virtual interrupts and PCI MSIs for example.
>
> - If mapped from the device-tree and #interrupt-cells is 2 (PAPR
> compliant), we use the second cell to set the appropriate type
>
> - If mapped from the device-tree and #interrupt-cells is 1 (current
> OPAL on P8 does that), we assume level sensitive since those are
> typically going to be the PSI LSIs which are level sensitive.
>
> Additionally, we mark the interrupts requested via the opal_interrupts
> property all level. This is a bit fishy but the best we can do until we
> fix OPAL to properly expose them with a complete descriptor. It is also
> correct for the current HW anyway as OPAL interrupts are currently PCI
> error and PSI interrupts which are level.
>
> Finally now that edge interrupts are properly identified, we can enable
> CONFIG_HARDIRQS_SW_RESEND which will make the core re-send them if
> they occur while masked, which some drivers rely upon.
>
> This fixes issues with lost interrupts on some Mellanox adapters.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/880a3d6afd068682d6386a0528
cheers
prev parent reply other threads:[~2016-08-09 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 2:39 [PATCH] powerpc/xics: Properly set Edge/Level type and enable resend Benjamin Herrenschmidt
2016-08-04 4:40 ` Michael Ellerman
2016-08-04 9:41 ` Benjamin Herrenschmidt
2016-08-05 6:56 ` Michael Ellerman
2016-08-09 11:26 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3s7sS54c6Mz9t23@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox