From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Segher Boessenkool <segher@kernel•crashing.org>, linuxppc-dev@ozlabs•org
Cc: markus@trippelsdorf•de, amodra@gmail•com
Subject: Re: powerpc: cmp -> cmpd for 64-bit
Date: Wed, 26 Oct 2016 21:21:11 +1100 (AEDT) [thread overview]
Message-ID: <3t3mJS0hfYz9sxS@ozlabs.org> (raw)
In-Reply-To: <551528846e6a2783184ba8a4228348a2fc9786bd.1475761214.git.segher@kernel.crashing.org>
On Thu, 2016-06-10 at 13:42:19 UTC, Segher Boessenkool wrote:
> PowerPC's "cmp" instruction has four operands. Normally people write
> "cmpw" or "cmpd" for the second cmp operand 0 or 1. But, frequently
> people forget, and write "cmp" with just three operands.
>
> With older binutils this is silently accepted as if this was "cmpw",
> while often "cmpd" is wanted. With newer binutils GAS will complain
> about this for 64-bit code. For 32-bit code it still silently assumes
> "cmpw" is what is meant.
>
> Signed-off-by: Segher Boessenkool <segher@kernel•crashing.org>
Applied to powerpc fixes, thanks.
I added:
Fixes: 948cf67c4726 ("powerpc: Add NAP mode support on Power7 in HV mode")
Cc: stable@vger•kernel.org # v3.0
https://git.kernel.org/powerpc/c/80f23935cadb1c654e81951f5a8b7c
cheers
next prev parent reply other threads:[~2016-10-26 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 13:42 [PATCH] powerpc: cmp -> cmpd for 64-bit Segher Boessenkool
2016-10-12 3:05 ` Michael Ellerman
2016-10-12 13:26 ` Segher Boessenkool
2016-10-12 17:00 ` Vaidyanathan Srinivasan
2016-10-26 10:21 ` Michael Ellerman [this message]
2016-12-14 3:31 ` Joel Stanley
2016-12-14 4:25 ` Segher Boessenkool
2016-12-14 11:02 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3t3mJS0hfYz9sxS@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=amodra@gmail$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=markus@trippelsdorf$(echo .)de \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox