From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Russell Currey <ruscur@russell•cc>, linuxppc-dev@lists•ozlabs.org
Cc: gwshan@linux•vnet.ibm.com, andrew.donnellan@au1•ibm.com,
Russell Currey <ruscur@russell•cc>
Subject: Re: powerpc/eeh: Refactor EEH PE reset functions
Date: Fri, 25 Nov 2016 11:04:11 +1100 (AEDT) [thread overview]
Message-ID: <3tPxBg6cdWz9t0Z@ozlabs.org> (raw)
In-Reply-To: <20161117050747.18250-1-ruscur@russell.cc>
On Thu, 2016-11-17 at 05:07:47 UTC, Russell Currey wrote:
> eeh_pe_reset and eeh_reset_pe are two different functions in the same
> file which do mostly the same thing. Not only is this confusing, but
> potentially causes disrepancies in functionality, notably eeh_reset_pe
> as it does not check return values for failure.
>
> Refactor this into the following:
>
> - eeh_pe_reset(): stays as is, performs a single operation, exported
> - eeh_pe_reset_full(): new, full reset process that calls eeh_pe_reset()
> - eeh_reset_pe(): removed and replaced by eeh_pe_reset_full()
> - eeh_reset_pe_once(): removed
>
>
> Signed-off-by: Russell Currey <ruscur@russell•cc>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/6654c9368a6ff75a36230d8eb94676
cheers
prev parent reply other threads:[~2016-11-25 0:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 5:07 [PATCH] powerpc/eeh: Refactor EEH PE reset functions Russell Currey
2016-11-17 23:59 ` Gavin Shan
2016-11-18 2:37 ` Russell Currey
2016-11-18 12:14 ` Michael Ellerman
2016-11-25 0:04 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3tPxBg6cdWz9t0Z@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=andrew.donnellan@au1$(echo .)ibm.com \
--cc=gwshan@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ruscur@russell$(echo .)cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox