From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Nicholas Piggin <npiggin@gmail•com>, linuxppc-dev@lists•ozlabs.org
Cc: Nicholas Piggin <npiggin@gmail•com>, Alan Modra <amodra@gmail•com>
Subject: Re: [1/3] powerpc/64e: convert cmpi to cmpwi in head_64.S
Date: Tue, 29 Nov 2016 23:58:11 +1100 (AEDT) [thread overview]
Message-ID: <3tSk9v3tzcz9t1C@ozlabs.org> (raw)
In-Reply-To: <20161123130209.1667-2-npiggin@gmail.com>
On Wed, 2016-11-23 at 13:02:07 UTC, Nicholas Piggin wrote:
> >From 80f23935cadb ("powerpc: Convert cmp to cmpd in idle enter sequence"):
>
> PowerPC's "cmp" instruction has four operands. Normally people write
> "cmpw" or "cmpd" for the second cmp operand 0 or 1. But, frequently
> people forget, and write "cmp" with just three operands.
>
> With older binutils this is silently accepted as if this was "cmpw",
> while often "cmpd" is wanted. With newer binutils GAS will complain
> about this for 64-bit code. For 32-bit code it still silently assumes
> "cmpw" is what is meant.
>
> In this instance the code comes directly from ISA v2.07, including the
> cmp, but cmpd is correct. Backport to stable so that new toolchains can
> build old kernels.
>
> In this case, cmpwi is called for, so this is just a build fix for
> new toolchians.
>
> Stable: v3.0
> Cc: Segher Boessenkool <segher@kernel•crashing.org>
> Signed-off-by: Nicholas Piggin <npiggin@gmail•com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f87f253bac3ce4a4eb2a60a1ae604d
cheers
next prev parent reply other threads:[~2016-11-29 12:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 13:02 [PATCH 0/3] minor build fixes Nicholas Piggin
2016-11-23 13:02 ` [PATCH 1/3] powerpc/64e: convert cmpi to cmpwi in head_64.S Nicholas Piggin
2016-11-29 12:58 ` Michael Ellerman [this message]
2016-11-23 13:02 ` [PATCH 2/3] powerpc: allow compilation on cross-endian toolchain Nicholas Piggin
2016-11-24 9:04 ` Nicholas Piggin
2016-11-26 3:00 ` Nicholas Piggin
2016-11-26 7:30 ` Michael Ellerman
2016-11-27 2:46 ` Nicholas Piggin
2017-02-02 8:08 ` Naveen N. Rao
2017-03-08 7:25 ` [2/3] " Michael Ellerman
2016-11-23 13:02 ` [PATCH 3/3] powerpc/64e: don't branch to dot symbols Nicholas Piggin
2016-11-29 12:58 ` [3/3] " Michael Ellerman
2016-11-23 23:03 ` [PATCH 0/3] minor build fixes Alan Modra
2016-11-24 1:04 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3tSk9v3tzcz9t1C@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=amodra@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox