From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Nicholas Piggin <npiggin@gmail•com>,
christophe leroy <christophe.leroy@c-s•fr>
Cc: Scott Wood <oss@buserror•net>, linuxppc-dev@lists•ozlabs.org
Subject: Re: [3/3] powerpc/8xx: xmon compile fix
Date: Tue, 30 May 2017 19:11:20 +1000 (AEST) [thread overview]
Message-ID: <3wcSX82gZbz9s7M@ozlabs.org> (raw)
In-Reply-To: <20170512104707.5393eaa1@roar.ozlabs.ibm.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]
On Fri, 2017-05-12 at 00:47:07 UTC, Nicholas Piggin wrote:
> On Thu, 11 May 2017 20:52:56 +0200
> christophe leroy <christophe.leroy@c-s•fr> wrote:
>
> > Le 11/05/2017 à 19:14, christophe leroy a écrit :
> > >
> > >
> > > Le 11/05/2017 à 17:15, Nicholas Piggin a écrit :
> > >> Cc: Scott Wood <oss@buserror•net>
> > >> Cc: Christophe Leroy <christophe.leroy@c-s•fr>
> > >> Signed-off-by: Nicholas Piggin <npiggin@gmail•com>
> > >> ---
> > >> arch/powerpc/xmon/xmon.c | 5 ++++-
> > >> 1 file changed, 4 insertions(+), 1 deletion(-)
> > >>
> > >> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
> > >> index f11f65634aab..ec420b0e6e88 100644
> > >> --- a/arch/powerpc/xmon/xmon.c
> > >> +++ b/arch/powerpc/xmon/xmon.c
> > >> @@ -1242,10 +1242,13 @@ bpt_cmds(void)
> > >> {
> > >> int cmd;
> > >> unsigned long a;
> > >> - int mode, i;
> > >> + int i;
> > >> struct bpt *bp;
> > >> +#ifndef CONFIG_8xx
> > >
> > > Would be better to use CONFIG_PPC_8xx
> > >
> > > As stated in arch/powerpc/platform/Kconfig.cputype, CONFIG_8xx is temp
> > > to handle compat with arch/ppc, and we are trying to get rid of it
> >
> > I had the same comment in https://patchwork.ozlabs.org/patch/700354/
> > I also suggested to move the relevant declarations inside the switch()
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/09b6c1129f899c72d70b8bea360206
cheers
next prev parent reply other threads:[~2017-05-30 9:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-11 15:15 [PATCH 1/3] powerpc/powernv: Fix CPU_HOTPLUG=n idle.c compile error Nicholas Piggin
2017-05-11 15:15 ` [PATCH 2/3] powerpc/32: tlbie provide L operand explicitly Nicholas Piggin
2017-05-12 3:35 ` Michael Ellerman
2017-05-12 10:31 ` Nick Piggin
2017-05-11 15:15 ` [PATCH 3/3] powerpc/8xx: xmon compile fix Nicholas Piggin
2017-05-11 17:14 ` christophe leroy
2017-05-11 18:52 ` christophe leroy
2017-05-11 19:30 ` Nicholas Piggin
2017-05-12 0:47 ` Nicholas Piggin
2017-05-12 5:37 ` Christophe LEROY
2017-05-26 7:24 ` Michael Ellerman
2017-05-26 16:20 ` David Laight
2017-05-29 5:21 ` Michael Ellerman
2017-05-30 9:11 ` Michael Ellerman [this message]
2017-05-12 9:19 ` [PATCH 1/3] powerpc/powernv: Fix CPU_HOTPLUG=n idle.c compile error Gautham R Shenoy
2017-05-30 9:11 ` [1/3] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3wcSX82gZbz9s7M@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
--cc=oss@buserror$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox