From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Murilo Opsfelder Araujo <mopsfelder@gmail•com>,
linux-kernel@vger•kernel.org
Cc: linux-watchdog@vger•kernel.org,
Murilo Opsfelder Araujo <mopsfelder@gmail•com>,
Wim Van Sebroeck <wim@iguana•be>,
linuxppc-dev@lists•ozlabs.org, Guenter Roeck <linux@roeck-us•net>
Subject: Re: [v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies
Date: Mon, 19 Jun 2017 22:25:35 +1000 (AEST) [thread overview]
Message-ID: <3wrqv32nQZz9s7v@ozlabs.org> (raw)
In-Reply-To: <20170529132628.10803-1-mopsfelder@gmail.com>
On Mon, 2017-05-29 at 13:26:28 UTC, Murilo Opsfelder Araujo wrote:
> drivers/watchdog/wdrtas.c uses symbols defined in arch/powerpc/kernel/rtas.c,
> which are exported iff CONFIG_PPC_RTAS is selected. Building wdrtas.c without
> setting CONFIG_PPC_RTAS throws the following errors:
>
> ERROR: ".rtas_token" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: "rtas_data_buf" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: "rtas_data_buf_lock" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: ".rtas_get_sensor" [drivers/watchdog/wdrtas.ko] undefined!
> ERROR: ".rtas_call" [drivers/watchdog/wdrtas.ko] undefined!
>
> This was identified during a randconfig build where CONFIG_WATCHDOG_RTAS=m and
> CONFIG_PPC_RTAS was not set. Logs are here:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12982152/
>
> This patch fixes the issue by updating CONFIG_WATCHDOG_RTAS to depend on just
> CONFIG_PPC_RTAS, removing COMPILE_TEST entirely.
>
> Signed-off-by: Murilo Opsfelder Araujo <mopsfelder@gmail•com>
> Reviewed-by: Guenter Roeck <linux@roeck-us•net>
> Acked-by: Michael Ellerman <mpe@ellerman•id.au>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/42bed042556261b56aa92e05f4f388
cheers
prev parent reply other threads:[~2017-06-19 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 13:26 [PATCH v2] drivers/watchdog/Kconfig: Update CONFIG_WATCHDOG_RTAS dependencies Murilo Opsfelder Araujo
2017-05-29 19:07 ` Guenter Roeck
2017-05-30 10:55 ` Michael Ellerman
2017-06-19 12:25 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3wrqv32nQZz9s7v@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mopsfelder@gmail$(echo .)com \
--cc=wim@iguana$(echo .)be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox