From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Balbir Singh <bsingharora@gmail•com>, linuxppc-dev@lists•ozlabs.org
Subject: Re: [v2] powerpc/kexec: Fix radix to hash kexec
Date: Tue, 11 Jul 2017 22:48:24 +1000 (AEST) [thread overview]
Message-ID: <3x6MMF0J7cz9s8J@ozlabs.org> (raw)
In-Reply-To: <20170629115726.11060-1-bsingharora@gmail.com>
On Thu, 2017-06-29 at 11:57:26 UTC, Balbir Singh wrote:
> This patch fixes a crash seen while doing a kexec from
> radix mode to hash mode. Key 0 is special in hash and
> used in the RPN by default, we set the key values to 0
> today. In radix mode key 0 is used to control
> supervisor<->user access. In hash key 0 is used by default,
> so the first instruction after the switch causes a crash on
> kexec.
>
> This patch fixes
> (3b10d00 powerpc/mm/radix: Prevent kernel execution of user space)
> The commit above introduced setting of IAMR and AMOR values to
> prevent execution of user mode instructions from supervisor mode.
> We need to clean up these SPR's on kexec.
>
> Reported-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Signed-off-by: Balbir Singh <bsingharora@gmail•com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/1e2a516e89fc412a754327522ab271
cheers
prev parent reply other threads:[~2017-07-11 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 11:57 [PATCH v2] powerpc/kexec: Fix radix to hash kexec Balbir Singh
2017-07-11 12:48 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3x6MMF0J7cz9s8J@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=bsingharora@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox