From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Benjamin Herrenschmidt <benh@kernel•crashing.org>,
linuxppc-dev@lists•ozlabs.org
Cc: aneesh.kumar@linux•vnet.ibm.com, npiggin@gmail•com
Subject: Re: [3/6] powerpc/mm: Ensure cpumask update is ordered
Date: Wed, 23 Aug 2017 22:01:52 +1000 (AEST) [thread overview]
Message-ID: <3xcmHh2ZQZz9sCZ@ozlabs.org> (raw)
In-Reply-To: <20170724042803.25848-3-benh@kernel.crashing.org>
On Mon, 2017-07-24 at 04:28:00 UTC, Benjamin Herrenschmidt wrote:
> There is no guarantee that the various isync's involved with
> the context switch will order the update of the CPU mask with
> the first TLB entry for the new context being loaded by the HW.
>
> Be safe here and add a memory barrier to order any subsequent
> load/store which may bring entries into the TLB.
>
> The corresponding barrier on the other side already exists as
> pte updates use pte_xchg() which uses __cmpxchg_u64 which has
> a sync after the atomic operation.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Reviewed-by: Nicholas Piggin <npiggin@gmail•com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/1a92a80ad386a1a6e3b36d576d52a1
cheers
next prev parent reply other threads:[~2017-08-23 12:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-24 4:27 [PATCH 1/6] powerpc/mm: Move pgdir setting into a helper Benjamin Herrenschmidt
2017-07-24 4:27 ` [PATCH 2/6] powerpc/mm: Avoid double irq save/restore in activate_mm Benjamin Herrenschmidt
2017-07-24 4:28 ` [PATCH 3/6] powerpc/mm: Ensure cpumask update is ordered Benjamin Herrenschmidt
2017-07-24 11:20 ` Nicholas Piggin
2017-07-24 20:54 ` Benjamin Herrenschmidt
2017-08-11 11:06 ` Nicholas Piggin
2017-08-11 22:40 ` Benjamin Herrenschmidt
2017-08-17 12:58 ` Michael Ellerman
2017-08-23 12:01 ` Michael Ellerman [this message]
2017-07-24 4:28 ` [PATCH 4/6] powerpc/mm: Use mm_is_thread_local() instread of open-coding Benjamin Herrenschmidt
2017-07-24 4:28 ` [PATCH 5/6] powerpc/mm: Optimize detection of thread local mm's Benjamin Herrenschmidt
2017-07-24 11:25 ` Nicholas Piggin
2017-07-24 13:46 ` Michael Ellerman
2017-07-25 0:34 ` Nicholas Piggin
2017-07-25 12:00 ` Michael Ellerman
2017-07-24 20:58 ` Benjamin Herrenschmidt
2017-07-25 0:44 ` Nicholas Piggin
2017-07-25 1:03 ` Benjamin Herrenschmidt
2017-07-25 10:55 ` Nicholas Piggin
2017-08-04 12:06 ` Frederic Barrat
2017-08-04 12:58 ` Benjamin Herrenschmidt
2017-08-21 17:27 ` Frederic Barrat
2017-08-21 17:35 ` Benjamin Herrenschmidt
2017-08-22 13:18 ` Frederic Barrat
2017-08-22 16:55 ` Benjamin Herrenschmidt
2017-08-24 16:40 ` Frederic Barrat
2017-08-24 18:47 ` Benjamin Herrenschmidt
2017-08-25 4:53 ` Frederic Barrat
2017-08-25 7:44 ` Benjamin Herrenschmidt
2017-08-25 8:03 ` Frederic Barrat
2017-08-22 4:28 ` Michael Ellerman
2017-07-24 4:28 ` [PATCH 6/6] powerpc/mm: Make switch_mm_irqs_off() out of line Benjamin Herrenschmidt
2017-08-24 12:37 ` [1/6] powerpc/mm: Move pgdir setting into a helper Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3xcmHh2ZQZz9sCZ@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=aneesh.kumar@linux$(echo .)vnet.ibm.com \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox