From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Vaibhav Jain <vaibhav@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org,
Frederic Barrat <fbarrat@linux•vnet.ibm.com>
Cc: Philippe Bergheaud <philippe.bergheaud@fr•ibm.com>,
Vaibhav Jain <vaibhav@linux•vnet.ibm.com>,
stable@vger•kernel.org, Alastair D'Silva <alastair@linux•ibm.com>,
Andrew Donnellan <andrew.donnellan@au1•ibm.com>,
Christophe Lombard <christophe_lombard@fr•ibm.com>
Subject: Re: [v3] cxl: Check if vphb exists before iterating over AFU devices
Date: Fri, 24 Nov 2017 20:46:40 +1100 (AEDT) [thread overview]
Message-ID: <3yjrtn33cvz9s71@ozlabs.org> (raw)
In-Reply-To: <20171123033857.13122-1-vaibhav@linux.vnet.ibm.com>
On Thu, 2017-11-23 at 03:38:57 UTC, Vaibhav Jain wrote:
> During an eeh a kernel-oops is reported if no vPHB is allocated to the
> AFU. This happens as during AFU init, an error in creation of vPHB is
> a non-fatal error. Hence afu->phb should always be checked for NULL
> before iterating over it for the virtual AFU pci devices.
>
> This patch fixes the kenel-oops by adding a NULL pointer check for
> afu->phb before it is dereferenced.
>
> Fixes: 9e8df8a2196("cxl: EEH support")
> Cc: stable@vger•kernel.org
> Signed-off-by: Vaibhav Jain <vaibhav@linux•vnet.ibm.com>
> Acked-by: Andrew Donnellan <andrew.donnellan@au1•ibm.com>
> Acked-by: Frederic Barrat <fbarrat@linux•vnet.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/12841f87b7a8ceb3d54f171660f72a
cheers
prev parent reply other threads:[~2017-11-24 9:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 3:38 [PATCH v3] cxl: Check if vphb exists before iterating over AFU devices Vaibhav Jain
2017-11-23 3:41 ` Andrew Donnellan
2017-11-23 10:58 ` Frederic Barrat
2017-11-24 9:46 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3yjrtn33cvz9s71@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=alastair@linux$(echo .)ibm.com \
--cc=andrew.donnellan@au1$(echo .)ibm.com \
--cc=christophe_lombard@fr$(echo .)ibm.com \
--cc=fbarrat@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=philippe.bergheaud@fr$(echo .)ibm.com \
--cc=stable@vger$(echo .)kernel.org \
--cc=vaibhav@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox