From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Vaibhav Jain <vaibhav@linux•vnet.ibm.com>,
linuxppc-dev@lists•ozlabs.org,
Frederic Barrat <fbarrat@linux•vnet.ibm.com>
Cc: Philippe Bergheaud <philippe.bergheaud@fr•ibm.com>,
Alastair D'Silva <alastair@linux•ibm.com>,
Vaibhav Jain <vaibhav@linux•vnet.ibm.com>,
Andrew Donnellan <andrew.donnellan@au1•ibm.com>,
Christophe Lombard <christophe_lombard@fr•ibm.com>
Subject: Re: [v2] cxl: Check if PSL data-cache is available before issue flush request
Date: Wed, 14 Mar 2018 20:27:47 +1100 (AEDT) [thread overview]
Message-ID: <401RGD0D76z9sVV@ozlabs.org> (raw)
In-Reply-To: <20180215154924.22005-1-vaibhav@linux.vnet.ibm.com>
On Thu, 2018-02-15 at 15:49:24 UTC, Vaibhav Jain wrote:
> PSL9D doesn't have a data-cache that needs to be flushed before
> resetting the card. However when cxl tries to flush data-cache on such
> a card, it times-out as PSL_Control register never indicates flush
> operation complete due to missing data-cache. This is usually
> indicated in the kernel logs with this message:
>
> "WARNING: cache flush timed out"
>
> To fix this the patch checks PSL_Debug register CDC-Field(BIT:27)
> which indicates the absence of a data-cache and sets a flag
> 'no_data_cache' in 'struct cxl_native' to indicate this. When
> cxl_data_cache_flush() is called it checks the flag and if set bails
> out early without requesting a data-cache flush operation to the PSL.
>
> Signed-off-by: Vaibhav Jain <vaibhav@linux•vnet.ibm.com>
> Acked-by: Andrew Donnellan <andrew.donnellan@au1•ibm.com>
> Acked-by: Frederic Barrat <fbarrat@linux•vnet.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/94322ed8e857e3b2a33cf75118051a
cheers
prev parent reply other threads:[~2018-03-14 9:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 15:49 [PATCH v2] cxl: Check if PSL data-cache is available before issue flush request Vaibhav Jain
2018-02-16 2:08 ` Andrew Donnellan
2018-02-16 9:29 ` Frederic Barrat
2018-03-14 9:27 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=401RGD0D76z9sVV@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=alastair@linux$(echo .)ibm.com \
--cc=andrew.donnellan@au1$(echo .)ibm.com \
--cc=christophe_lombard@fr$(echo .)ibm.com \
--cc=fbarrat@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=philippe.bergheaud@fr$(echo .)ibm.com \
--cc=vaibhav@linux$(echo .)vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox