From: Alistair Popple <alistair@popple•id.au>
To: linuxppc-dev@lists•ozlabs.org
Cc: Jeremy Kerr <jeremy.kerr@au1•ibm.com>, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] powerpc/powernv: Support OPAL requested heartbeat
Date: Fri, 14 Nov 2014 14:01:50 +1100 [thread overview]
Message-ID: <40458133.nYBXtuXJmS@mexican> (raw)
In-Reply-To: <1415772194.5124.37.camel@kernel.crashing.org>
Hi Ben,
On Wed, 12 Nov 2014 17:03:14 Benjamin Herrenschmidt wrote:
<snip>
> +
> +static int kopald(void *unused)
> +{
> + set_freezable();
> + do {
> + try_to_freeze();
> + opal_poll_events(NULL);
Do we need to check for outstanding events (and call opal_do_notifier)? The
Linux OPAL-IPMI interface signals an event which the interrupt handler
(opal_interrupt) checks for, but if interrupts aren't functional no event will
be signalled and hence the Linux IPMI layer won't get a response.
It's probably only an issue for lab bring up though as I would expect
interrupts to generally be working...
> + msleep_interruptible(opal_heartbeat);
> + } while (!kthread_should_stop());
> +
> + return 0;
> +}
> +
Regards,
Alistair
next prev parent reply other threads:[~2014-11-14 3:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 6:03 [PATCH] powerpc/powernv: Support OPAL requested heartbeat Benjamin Herrenschmidt
2014-11-13 5:29 ` Michael Ellerman
2014-11-13 6:42 ` Benjamin Herrenschmidt
2014-11-13 6:46 ` Jeremy Kerr
2014-11-13 16:59 ` [PATCH] " Paul Clarke
2014-11-13 20:35 ` Benjamin Herrenschmidt
2014-11-14 3:01 ` Alistair Popple [this message]
2014-11-14 4:26 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40458133.nYBXtuXJmS@mexican \
--to=alistair@popple$(echo .)id.au \
--cc=jeremy.kerr@au1$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox