From: Michael Ellerman <patch-notifications@ellerman•id.au>
To: Sam Bobroff <sam.bobroff@au1•ibm.com>, linuxppc-dev@lists•ozlabs.org
Subject: Re: [v2,1/9] powerpc/eeh: Remove eeh_handle_event()
Date: Thu, 29 Mar 2018 01:13:25 +1100 (AEDT) [thread overview]
Message-ID: <40B8xK5LGpz9s12@ozlabs.org> (raw)
In-Reply-To: <d3d01073da02a5eb844cc8998fdac602b8121b62.1521427331.git.sam.bobroff@au1.ibm.com>
On Mon, 2018-03-19 at 02:46:20 UTC, Sam Bobroff wrote:
> The function eeh_handle_event(pe) does nothing other than switching
> between calling eeh_handle_normal_event(pe) and
> eeh_handle_special_event(). However it is only called in two places,
> one where pe can't be NULL and the other where it must be NULL (see
> eeh_event_handler()) so it does nothing but obscure the flow of
> control.
>
> So, remove it.
>
> Signed-off-by: Sam Bobroff <sam.bobroff@au1•ibm.com>
> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs•ru>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/68701780712f7ddb2fa81032aa1b4a
cheers
next prev parent reply other threads:[~2018-03-28 14:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 2:45 [PATCH v2 0/9] EEH refactoring 1 Sam Bobroff
2018-03-19 2:46 ` [PATCH v2 1/9] powerpc/eeh: Remove eeh_handle_event() Sam Bobroff
2018-03-21 5:17 ` Alexey Kardashevskiy
2018-03-28 14:13 ` Michael Ellerman [this message]
2018-03-19 2:46 ` [PATCH v2 2/9] powerpc/eeh: Manage EEH_PE_RECOVERING inside eeh_handle_normal_event() Sam Bobroff
2018-03-21 5:17 ` Alexey Kardashevskiy
2018-03-19 2:46 ` [PATCH v2 3/9] powerpc/eeh: Fix misleading comment in __eeh_addr_cache_get_device() Sam Bobroff
2018-03-21 5:17 ` Alexey Kardashevskiy
2018-03-19 2:46 ` [PATCH v2 4/9] powerpc/eeh: Remove misleading test in eeh_handle_normal_event() Sam Bobroff
2018-03-21 5:18 ` Alexey Kardashevskiy
2018-03-19 2:47 ` [PATCH v2 5/9] powerpc/eeh: Rename frozen_bus to bus " Sam Bobroff
2018-03-21 5:18 ` Alexey Kardashevskiy
2018-03-19 2:48 ` [PATCH v2 6/9] powerpc/eeh: Clarify arguments to eeh_reset_device() Sam Bobroff
2018-03-21 5:18 ` Alexey Kardashevskiy
2018-03-19 2:49 ` [PATCH v2 7/9] powerpc/eeh: Remove always-true tests in eeh_reset_device() Sam Bobroff
2018-03-21 5:18 ` Alexey Kardashevskiy
2018-03-19 2:49 ` [PATCH v2 8/9] powerpc/eeh: Factor out common code eeh_reset_device() Sam Bobroff
2018-03-20 8:31 ` kbuild test robot
2018-03-21 2:06 ` [PATCH v3 " Sam Bobroff
2018-03-21 5:18 ` Alexey Kardashevskiy
2018-03-19 2:49 ` [PATCH v2 9/9] powerpc/eeh: Add eeh_state_active() helper Sam Bobroff
2018-03-20 4:05 ` kbuild test robot
2018-03-21 5:20 ` Alexey Kardashevskiy
2018-03-21 5:16 ` [PATCH v2 0/9] EEH refactoring 1 Alexey Kardashevskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40B8xK5LGpz9s12@ozlabs.org \
--to=patch-notifications@ellerman$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=sam.bobroff@au1$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox