Subject: Re: [PATCH V2 1/2] Maple: register CPC925 EDAC device on all boards with CPC925

From: Segher Boessenkool <[email-masked]>
Date: Mon, 23 May 2011 17:40:40 +0200

> Currently Maple setup code creates cpc925_edac device only on
> Motorola ATCA-6101 blade. Make setup code check bridge revision
> and enable EDAC on all U3H bridges.
>
> Verified on Momentum MapleD (ppc970fx kit) board.
>
> Signed-off-by: Dmitry Eremin-Solenikov <[email-masked]>

Acked-by: Segher Boessenkool <[email-masked]>

One tiny thing:

> +	if (rev >= 0x34 && rev <= 0x3f) { /* U3H */
> +		printk(KERN_ERR "%s: Non-CPC925(U3H) bridge revision: %02x\n",
> +			__func__, rev);
> +		return -ENODEV;
> +	}

That's not really an error, is it?

Segher