From: "Farber, Eliav" <farbere@amazon•com>
To: Jiri Slaby <jirislaby@kernel•org>,
"linux@armlinux•org.uk" <linux@armlinux•org.uk>,
"catalin.marinas@arm•com" <catalin.marinas@arm•com>,
"will@kernel•org" <will@kernel•org>,
"mpe@ellerman•id.au" <mpe@ellerman•id.au>,
"npiggin@gmail•com" <npiggin@gmail•com>,
"christophe.leroy@csgroup•eu" <christophe.leroy@csgroup•eu>,
"naveen@kernel•org" <naveen@kernel•org>,
"maddy@linux•ibm.com" <maddy@linux•ibm.com>,
"paul.walmsley@sifive•com" <paul.walmsley@sifive•com>,
"palmer@dabbelt•com" <palmer@dabbelt•com>,
"aou@eecs•berkeley.edu" <aou@eecs•berkeley.edu>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"akpm@linux-foundation•org" <akpm@linux-foundation•org>,
"bhe@redhat•com" <bhe@redhat•com>,
"hbathini@linux•ibm.com" <hbathini@linux•ibm.com>,
"sourabhjain@linux•ibm.com" <sourabhjain@linux•ibm.com>,
"adityag@linux•ibm.com" <adityag@linux•ibm.com>,
"songshuaishuai@tinylab•org" <songshuaishuai@tinylab•org>,
"takakura@valinux•co.jp" <takakura@valinux•co.jp>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"linux-riscv@lists•infradead.org"
<linux-riscv@lists•infradead.org>
Cc: "Chocron, Jonathan" <jonnyc@amazon•com>
Subject: RE: [PATCH v5 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation
Date: Wed, 4 Dec 2024 11:40:55 +0000 [thread overview]
Message-ID: <4192766c8f02494a82db68f5732c6dd2@amazon.com> (raw)
On 12/4/2024 1:02 PM, Jiri Slaby wrote:
>> +
>> +config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD
>> + bool "Clear forwarded VM interrupts during kexec"
>> + default n
>> + help
>> + When enabled, this option allows the kernel to clear the active state
>> + of interrupts that are forwarded to virtual machines (VMs) during a
>> + machine kexec. For interrupts that are not forwarded, if supported,
>> + the kernel will attempt to trigger an End of Interrupt (EOI).
>
> This caught my attention. It looks like you want to allow people toggling it? I believe only arch code should turn it on as you do by "select", not users.
Thomas Gleixner has also commented about it:
"
This should not be user selectable. Just keep it as:
config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD
bool
which defaults to 'n'. Just add a comment what this is about like it's done with the other options in that file which are only selectable.
"
I will fix it in v6.
I'm just waiting for a reply if the new configuration option should be
placed inside or after the following section:
```
menu "IRQ subsystem"
endmenu
```
Thanks, Eliav
next reply other threads:[~2024-12-04 11:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 11:40 Farber, Eliav [this message]
2024-12-04 14:07 ` [PATCH v5 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2024-12-03 12:55 Farber, Eliav
2024-12-03 16:36 ` Thomas Gleixner
2024-11-30 20:11 [PATCH v5 0/2] Improve interrupt handling during machine kexec Eliav Farber
2024-11-30 20:11 ` [PATCH v5 1/2] kexec: Consolidate machine_kexec_mask_interrupts() implementation Eliav Farber
2024-12-03 11:04 ` Thomas Gleixner
2024-12-04 11:02 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4192766c8f02494a82db68f5732c6dd2@amazon.com \
--to=farbere@amazon$(echo .)com \
--cc=adityag@linux$(echo .)ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=bhe@redhat$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=hbathini@linux$(echo .)ibm.com \
--cc=jirislaby@kernel$(echo .)org \
--cc=jonnyc@amazon$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)ibm.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=naveen@kernel$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=songshuaishuai@tinylab$(echo .)org \
--cc=sourabhjain@linux$(echo .)ibm.com \
--cc=takakura@valinux$(echo .)co.jp \
--cc=tglx@linutronix$(echo .)de \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox