From: "Mark A. Greer" <mgreer@mvista•com>
To: Kumar Gala <galak@somerset•sps.mot.com>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: RFC: [PATCH] platform device driver model support
Date: Wed, 12 Jan 2005 16:30:32 -0700 [thread overview]
Message-ID: <41E5B318.3060304@mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0501120133080.21665@blarg.somerset.sps.mot.com>
Kumar Gala wrote:
>All,
>
>Please take a look at the following patch. It adds driver model support
>via platform devices to 85xx. This is originally based on patches from
>Jason M.
>
>The idea behind the code is that for a give family: 4xx, 8xx, 82xx, 83xx,
>85xx, 86xx we will have structure defns for the following:
>
>enum ppc_soc_devices
>in asm-ppc/<family.h>:
> list of all unique devices in the family
>
>struct platform_device soc_platform_devices[]
>in arch/ppc/platforms/<family>/<family>_devices.c:
> describes all platform devices that exist in the family
>
>struct soc_spec soc_specs[]
>in arch/ppc/platforms/<family>/<family>_soc.c:
> describes each unique chip in the family and what devices it has
>
>Plus the following functions:
>
>identify_soc_by_id() -- determine soc by an int id
>identify_soc_by_name() -- determin soc by name (useful in some 82xx cases)
>ppc_soc_get_pdata() -- get platform_data pointer so board code can modify
>ppc_soc_update_paddr() -- update iomem resources with a given paddr
>
>Please provide feedback, I want to get this into 2.6.11 for 85xx.
>
>
My $0.02.
I didn't go thru in complete detail but I like the idea. I have a
couple minor comments, though.
1) Can we pick something other than 'soc' since the Marvell bridges
really aren't SOCs? I don't really know what is better but just to
throw something out, how about haing them all look like ppc_pd_xxx()?
2) In 8540_ads.c you're digging out platform_device entries and
modifying them in your mpc8540ads_setup_arch() routine. I think the
platform_device "way" of doing that would be to make your mods via the
platform_notify() hook (eventually called by device_add() which was
ultimately called from platform_add_devices()).
Mark
next prev parent reply other threads:[~2005-01-13 0:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-12 7:43 RFC: [PATCH] platform device driver model support Kumar Gala
2005-01-12 8:36 ` Eugene Surovegin
2005-01-12 14:41 ` Kumar Gala
2005-01-12 21:14 ` Matt Porter
2005-01-12 21:28 ` Matt Porter
2005-01-14 19:13 ` Andrew May
2005-01-14 19:14 ` Kumar Gala
2005-01-12 23:30 ` Mark A. Greer [this message]
2005-01-13 4:19 ` Kumar Gala
2005-01-13 17:34 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41E5B318.3060304@mvista.com \
--to=mgreer@mvista$(echo .)com \
--cc=galak@somerset$(echo .)sps.mot.com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox