Subject: Re: [PATCH][PPC32] PPC4xx ocp ide rewrite/cleanup

From: Andre' Draszik <[email-masked]>
Date: Sat, 19 Feb 2005 10:28:37 +0100

Hi,

Matt Porter wrote:
> Ok, this one looks good save a few minor things that need done:

i will address these as soon as i have time again, i.e. on wednesday.

> 1) Rename from ibm_ocp_ide.[c|h] to ibm_stb_ide.[c|h] We want
>    rid of "ocp" in the file names since eventually 4xx will
>    convert to platform devices.

is diff -N appropriate for that and convenient for you? as said, i'm using 
the rsync mirror only, no bitkeeper.

> 2) Remove the #if 0'ed code...if it's not used it doesn't belong
>    in there.

ok.

> 3) Run Lindent on the driver.

ok.
Shall I send the new patch against the one I already sent or against the 
unpatched tree?

> What systems have you tested on?

On two different custom built boards both based on the redwood5 reference 
design.

a.