From: "Mark A. Greer" <mgreer@mvista•com>
To: James Chapman <jchapman@katalix•com>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH 2.6.11-rc4] ppc: add support for Radstone ppc7d boards
Date: Mon, 28 Feb 2005 13:53:30 -0700 [thread overview]
Message-ID: <422384CA.6090004@mvista.com> (raw)
In-Reply-To: <42235B0A.3070302@katalix.com>
Hi James,
All-in-all, this seems good but I have a few comments/questions.
Mark
--
James Chapman wrote:
> Add support for Radstone PPC7D PPC boards.
>
> Signed-off-by: James Chapman <jchapman@katalix•com>
>
> The Radstone PPC7D is a rugged ppc7447A VME card with
> Marvell Discovery-II dual GigE, dual PCI/PCI-X PMC sites,
> 4 UARTs, 2 high speed serial ports, USB and optional
> SCSI / VGA.
> diff -Nru a/arch/ppc/platforms/radstone_ppc7d.c
b/arch/ppc/platforms/radstone_ppc7d.c
> +void __init ppc7d_setup_peripherals(void)
> + val32 = mv64x60_read(&bh, MV64x60_PCI1_PCI_DECODE_CNTL);
> + val32 &= ~(1 << 3);
> + mv64x60_write(&bh, MV64x60_PCI1_PCI_DECODE_CNTL, val32);
Bit 3 is already cleared by the core code.
> + /* Setup P2P for PCI#0 */
> + val32 = mv64x60_read(&bh, MV64x60_PCI0_P2P_CONFIG);
> + val32 &= ~(0x00ffffff);
> + val32 |= ((bh.hose_a->first_busno & 0xff) << 16);
etc.
Do you really use the P2P bridge? Unless I missed something, I think it
remains disabled. You shouldn't need it unless you have PCI devices on
one hose directly accessing PCI devices on the other hose. The P2P
stuff seems complicated & unnecessary.
next prev parent reply other threads:[~2005-02-28 20:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-28 17:55 [PATCH 2.6.11-rc4] ppc: add support for Radstone ppc7d boards James Chapman
2005-02-28 20:53 ` Mark A. Greer [this message]
2005-02-28 21:31 ` James Chapman
2005-02-28 22:13 ` James Chapman
2005-02-28 22:24 ` Mark A. Greer
2005-03-01 19:29 ` James Chapman
2005-03-03 17:58 ` Mark A. Greer
2005-03-03 22:06 ` [PATCH 2.6.11-rc5] ppc32: add Radstone PPC7D platform support James Chapman
2005-03-03 22:50 ` James Chapman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=422384CA.6090004@mvista.com \
--to=mgreer@mvista$(echo .)com \
--cc=jchapman@katalix$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox