From: Vitaly Bordug <vbordug@ru•mvista.com>
To: Kumar Gala <galak@freescale•com>, linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to the stock linux-2.5 (updated)
Date: Thu, 21 Apr 2005 16:04:23 +0400 [thread overview]
Message-ID: <426796C7.3090501@ru.mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0504201401270.8563@linen.am.freescale.net>
Kumar Gala wrote:
>On Wed, 13 Apr 2005, Vitaly Bordug wrote:
>
>Finally, had some time to really look at this patch, comments are inline.
>Look for (galak). A few high level comments:
>
>Can we fold pq2ads_setup_hose into pq2ads_setup_pci?
>
No problem, I think...
> Also, is there
>anything to be done to unify m8260_setup_pci &
>pq2ads_setup_pci..
>
Well, in my opinion, m8260_setup_pci should be replaced with
pq2ads_setup_pci, as far as they are intended to do the same (as I
mentioned in my very first PCI patch marked as RFC). But I actually
cannot test this stuff on anything other than 8272ads, so this way I'm
trying not to break existing code. The latter, BTW, currently has
limited functionality and I _guess_ I will not break anything if only
pq2ads_setup_pci remain. What do you think?
Other issues will be fixed shortly.
Thanks.
--
Sincerely,
Vitaly
next prev parent reply other threads:[~2005-04-21 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-13 15:08 [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to the stock linux-2.5 Vitaly
2005-04-13 17:36 ` [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to the stock linux-2.5 (updated) Vitaly Bordug
2005-04-20 20:56 ` Kumar Gala
2005-04-21 12:04 ` Vitaly Bordug [this message]
2005-04-21 14:00 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=426796C7.3090501@ru.mvista.com \
--to=vbordug@ru$(echo .)mvista.com \
--cc=galak@freescale$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox