From: Vitaly Bordug <vbordug@ru•mvista.com>
To: Rune Torgersen <runet@innovsys•com>
Cc: Tom Rini <trini@kernel•crashing.org>,
linuxppc-embedded list <linuxppc-embedded@ozlabs•org>
Subject: Re: [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to thestock linux-2.5 (updated)
Date: Thu, 21 Apr 2005 21:32:01 +0400 [thread overview]
Message-ID: <4267E391.5040006@ru.mvista.com> (raw)
In-Reply-To: <DCEAAC0833DD314AB0B58112AD99B93B85936A@ismail.innsys.innovsys.com>
[-- Attachment #1: Type: text/plain, Size: 1974 bytes --]
Rune Torgersen wrote:
> From: Vitaly Bordug [mailto:vbordug@ru•mvista.com]
> Sent: Thursday, April 21, 2005 10:29
>
>
>
>> This is all right. The only thing I still don't understand -
>>how this stuff work without PCI IRQ (don't know much about 8266
>>
>>
>though).
>
>
>>On my 8272 only one IRQ is produced and it should be demux'ed in order
>>for PCI devices to work. I agree that the siumcr stuff would better
>>
>>
>reside
>
>
>>in the firmware, and I have submitted related patch to the u-boot-users
>>
>>
>
>
>
>>list, but I have no idea whether it would be accepted or not
>>
>>
>(Wolfgang?).
>
>Ah.. That. I have that in a board specific file. Looks excactly like the
>implementation you have (for the 8266 port) For our internal board, it
>is quite different, so it should probably be in a board specific file
>(eg platforms/board_pci_setup.h)
>
>
>
>> The main point I actually dislike in the current m8260
>>
>>
>implementation
>
>
>>is that it adds defines for the PCI memory map while it exists
>>(and already included) in platforms/pq2ads.h. The memory maps are
>>nearly the same so we should decide which one will remain.
>>
>>
>
>I think I like the _LOWER/_UPPER/OFFSET variant. And it need to be
>possible to override it in board-files.
>I'll work in getting the 8266 PCI support I have to be integrated into
>the PQ2[F]ADS board support.
>
>
>
Great. Than I'll replace PCI_MSTR_* with _LOWER/_UPPER/OFFSET stuff in
the board-specific file so that it override m8260_pci.h defines.
Another issue - I want to keep the setup of the second outbound PCI
window (pcimask1/pcibr1) - since continuous mem/mmio/io is not flexible
enough - and to keep potarx/pobarx/pocmrx assignments as they are in
pq_... version (changing of course all relative constants to _LOWER/...
stuff).
Maybe the m8260.[c,h] should be renamed since this suites not only 826x
series?
Comments/objections?
--
Sincerely,
Vitaly
[-- Attachment #2: Type: text/html, Size: 3008 bytes --]
next prev parent reply other threads:[~2005-04-21 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-21 16:32 [PATCH 2.6.12-rc2] Freescale 8272ADS PCI bridge support to thestock linux-2.5 (updated) Rune Torgersen
2005-04-21 17:32 ` Vitaly Bordug [this message]
2005-04-21 18:03 ` Kumar Gala
2005-04-29 11:28 ` Vitaly Bordug
-- strict thread matches above, loose matches on Subject: below --
2005-04-29 22:23 Rune Torgersen
2005-04-21 17:42 Rune Torgersen
2005-04-21 14:54 Rune Torgersen
2005-04-21 15:29 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4267E391.5040006@ru.mvista.com \
--to=vbordug@ru$(echo .)mvista.com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
--cc=runet@innovsys$(echo .)com \
--cc=trini@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox