From: Vitaly Bordug <vbordug@ru•mvista.com>
To: Eugene Surovegin <ebs@ebshome•net>
Cc: linuxppc-embedded list <linuxppc-embedded@ozlabs•org>
Subject: Re: [RFC][PATCH 2.6.12-rc2 1/3] FCC Ethernet PlatformDevice support for 82xx
Date: Thu, 05 May 2005 17:56:20 +0400 [thread overview]
Message-ID: <427A2604.8040808@ru.mvista.com> (raw)
In-Reply-To: <20050504164624.GB11439@gate.ebshome.net>
[-- Attachment #1: Type: text/plain, Size: 2157 bytes --]
Eugene Surovegin wrote:
>On Wed, May 04, 2005 at 06:35:16PM +0400, Vitaly Bordug wrote:
>
>
>>This patch adds generic PlatformDevice support to the 82xx family.
>>Only FCC's exist currently in the structure, as there is the driver
>>which will utilize this.
>>
>>
>>
>
>[snip]
>
>
>
>>+#ifdef CONFIG_CPM2
>>+ identify_ppc_sys_by_id(cpm2_immr->im_memctl.memc_immr << 16);
>>+
>>+ /* Set up the MAC addresses for the FECs
>>+ */
>>+ fec = ppc_sys_platform_devices[MPC82xx_FCC1].dev.platform_data;
>>+ memcpy(fec->mac_addr,bi->bi_enetaddr,6);
>>+
>>+ fec = ppc_sys_platform_devices[MPC82xx_FCC2].dev.platform_data;
>>+#ifdef CONFIG_ADS8272
>>+ memcpy(fec->mac_addr,bi->bi_enet1addr,6);
>>+#else
>>+ memcpy(fec->mac_addr,bi->bi_enetaddr,6);
>>+ fec->macaddr[5] ^= 1;
>>+#endif
>>+#endif
>>
>>
>
>What is this? Why does common file contain board specific ifdefs????
>
>[snip]
>
>
>
>>+/* FCC1 Clock Source Configuration. There are board specific.
>>+ Can only choose from CLK9-12 */
>>+#if defined(CONFIG_ADS8272)
>>+#define F1_RXCLK 11
>>+#define F1_TXCLK 10
>>+#else
>>+#define F1_RXCLK 12
>>+#define F1_TXCLK 11
>>+#endif
>>
>>
>
>Same thing. Why on earth you continue current 8xxx trend of putting
>board specific crap into common files?
>
>
>
>>+
>>+/* FCC2 Clock Source Configuration. There are board specific.
>>+ Can only choose from CLK13-16 */
>>+#ifdef CONFIG_ADS8272
>>+#define F2_RXCLK 15
>>+#define F2_TXCLK 16
>>+#else
>>+#define F2_RXCLK 13
>>+#define F2_TXCLK 14
>>+#endif
>>
>>
>
>Ditto.
>
>
>
>>+#ifdef CONFIG_ADS8272
>>+#define PC_MDIO 0x00002000U
>>+#define PC_MDCK 0x00001000U
>>+#else
>>+#define PC_MDIO 0x00000004U
>>+#define PC_MDCK 0x00000020U
>>+#endif
>>
>>
>
>Ditto.
>
>
>
>>+ .name = "phyinterrupt",
>>+ .start = SIU_INT_IRQ5,
>>+ .end = SIU_INT_IRQ5,
>>+ .flags = IORESOURCE_IRQ,
>>+ },
>>
>>
>
>Why is this here? PHY interrupt routing is _board_ specific.
>
>
>
I have fixed these yet, but I think it will be more reasonable to update
this together with respective driver which I'll work on together with
Pantelis.
Thank you for review.
--
Sincerely,
Vitaly
[-- Attachment #2: Type: text/html, Size: 2974 bytes --]
next prev parent reply other threads:[~2005-05-05 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-04 14:35 [RFC][PATCH 2.6.12-rc2 1/3] FCC Ethernet PlatformDevice support for 82xx Vitaly Bordug
2005-05-04 16:46 ` Eugene Surovegin
2005-05-05 13:56 ` Vitaly Bordug [this message]
2005-05-05 14:30 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=427A2604.8040808@ru.mvista.com \
--to=vbordug@ru$(echo .)mvista.com \
--cc=ebs@ebshome$(echo .)net \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox